Skip to content
This repository has been archived by the owner on Jun 12, 2018. It is now read-only.

added functionality to automatically_authenticate #15

Merged
merged 16 commits into from Apr 16, 2013

Conversation

deanmalmgren
Copy link
Contributor

Hey Paul,

I just added a fbconsole.automatically_authenticate that addresses the issue I raised earlier this morning. It includes documentation and the addition of mechanize to the install requirements. To be honest, I'm not sure how nicely this plays with python 3 but I had some code written elsewhere that I was able to easily rip so I thought I'd post it as a candidate solution.

Happy to help modify this as necessary...

Cheers.
Dean

@pcardune
Copy link
Contributor

pcardune commented Apr 7, 2013

hmm, I guess I don't check my github notifications very often. Are you still interested in seeing this merged? Looks like a cool feature. I haven't reviewed the code that thoroughly yet, but if you still want to merge this, I'll look it over.

@deanmalmgren
Copy link
Contributor Author

ha; no worries.

I'd be happy to help merge it over as I think it is a feature many people would find useful. It has honestly been long enough that I've pretty much forgotten how everything worked, but I'd be happy to help with the merge.

@pcardune
Copy link
Contributor

pcardune commented Apr 8, 2013

Ok. I'll check it out and see if it works with python3

@pcardune
Copy link
Contributor

According to http://wwwsearch.sourceforge.net/mechanize/faq.html, python3 is not supported by mechanize yet, and in fact your branch breaks this package in python3. We could make this a python2.7 only feature until mechanize is ported, which I think some people are working on.

If you could make the following changes, I'll be happy to merge this in:

  • only add mechanize to install_requires if we are using python2.7 or below
  • make the import of mechanize in fbconsole.py optional
  • update the docs to explain that this is only supported in python2.7
  • throw an exception with a nice error message when someone tries to use automatically_authenticate() in python 3.

@deanmalmgren
Copy link
Contributor Author

There you go. I think that covers it. If anything doesn't check out, let me know and I can take another crack at it.

@pcardune
Copy link
Contributor

Great! looks good. There are a couple things that could be fixed (doesn't work if you have login approvals turned on) but I can try to get those to work on my own before I cut the next release.

pcardune added a commit that referenced this pull request Apr 16, 2013
added functionality to automatically_authenticate
@pcardune pcardune merged commit cffbbb1 into facebookarchive:master Apr 16, 2013
@pcardune
Copy link
Contributor

pcardune commented Nov 3, 2014

@deanmalmgren I'm thinking of removing this functionality from the package since it doesn't seem to be working anymore and I don't have time to support it. Are you interested in making an update to get it working again?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants