require call-time pass-by-reference

Summary: Will cherry pick to 3.24.

Reviewed By: dlreeves

Differential Revision: D6657922

fbshipit-source-id: ff2d60fe41e7506b1463c300471e42d15b6bb4bd

fb-examples/bin/shipit_buck.php-example

@@ -155,7 +155,7 @@ class ShipItBuck
     if (preg_match('/(^|\n)GitHub Author: (.*?)(\n|$)/si',
                    $changeset->getMessage()) &&
         preg_match('/<([^@]*)@fb\.com>/',
-                       $changeset->getAuthor(), $matches) &&
+                       $changeset->getAuthor(), &$matches) &&
         is_array($matches) &&
         isset($matches[1])) {
       if ($matches[1] === 'svcscm') {

fb-examples/bin/shipit_fbshipit.php-example

@@ -150,7 +150,7 @@ final class ShipItFBShipIt extends FBShipItCLI {
 
     foreach (self::getProjectFilePatterns() as $pattern) {
       $matches = [];
-      if (preg_match($pattern, $path, $matches)) {
+      if (preg_match($pattern, $path, &$matches)) {
         return !$public_projects->contains(strtolower($matches['project']));
       }
     }

fb-examples/lib/config/FBShipItConfig.php-example

@@ -126,7 +126,7 @@ abstract class FBShipItConfig implements IHasFBShipItCLIStaticConfig {
     }
     $paths = $paths->toArray();
     // Sort least specific to most specific.
-    sort($paths);
+    sort(&$paths);
     $roots = Set {};
     foreach ($paths as $path) {
       // If this path starts with any elements in the set of roots we have

fb-examples/lib/shipit/BuckEnvironmentCheckPhase.php-example

@@ -31,7 +31,7 @@ final class BuckEnvironmentCheckPhase extends EnvironmentCheckPhase {
       'ant', '-version',
     );
     $match = array();
-    if (!preg_match('@version ([0-9\.]+)@', $ant_v, $match)) {
+    if (!preg_match('@version ([0-9\.]+)@', $ant_v, &$match)) {
       fprintf(STDERR, "Couldn't identify ant version: %s\n", $ant_v);
       exit(1);
     }
@@ -45,7 +45,7 @@ final class BuckEnvironmentCheckPhase extends EnvironmentCheckPhase {
       'java', '-version',
     );
     $match = array();
-    if (!preg_match('@version "([0-9\.]+)@', $java_v, $match)) {
+    if (!preg_match('@version "([0-9\.]+)@', $java_v, &$match)) {
       fprintf(STDERR, "Couldn't identify java version: %s\n", $java_v);
       exit(1);
     }

fb-examples/lib/shipit/BuckGenerateDocsPhase.php-example

@@ -82,7 +82,7 @@ final class BuckGenerateDocsPhase extends ShipItPhase {
         1 => array('file', '/dev/null', 'w'),
         2 => array('file', '/dev/null', 'w'),
       ),
-      $pipes,
+      &$pipes,
       $sourcePath
     );
     fclose($pipes[0]);

fb-examples/lib/shipit/FBCommonFilters.php-example

@@ -300,7 +300,7 @@ final class FBCommonFilters {
       preg_match(
         '/<(?<author>[^@]*)@fb\.com>/',
         $changeset->getAuthor(),
-        $matches,
+        &$matches,
       ) && !self::isBotUser($matches['author'])
     ) {
       $pulled_by_unixname = $matches['author'];

fb-examples/lib/shipit/FBShipItCLI.php-example

@@ -69,7 +69,7 @@ abstract class FBShipItCLI
     }
     $paths = $paths->toArray();
     // Sort least specific to most specific.
-    sort($paths);
+    sort(&$paths);
     $roots = Set {};
     foreach ($paths as $path) {
       // If this path starts with any elements in the set of roots we have

fb-examples/lib/shipit/HHVMEnvironmentCheckPhase.php-example

@@ -16,7 +16,7 @@ final class HHVMEnvironmentCheckPhase extends EnvironmentCheckPhase {
   public function runImpl(ShipItBaseConfig $config): void {
     $gcc_check_cmd = "gcc --version";
     $gcc_check_output = array();
-    exec($gcc_check_cmd, $gcc_check_output);
+    exec($gcc_check_cmd, &$gcc_check_output);
     if (
       strpos(
         implode("", $gcc_check_output),

src/importit/filter/ImportItPathFilters.php

@@ -55,7 +55,7 @@ public static function invertShipIt(
     // that if two src path entries exist such that one of them is a prefix of
     // the other, the prefix always appears last.  This ensures that mappings
     // for subdirectories always take precedence over less-specific mappings.
-    krsort($reverse_mapping);
+    krsort(&$reverse_mapping);
 
     return $reverse_mapping->toImmMap();
   }

src/shipit/ShipItGitHubUtils.php

@@ -179,7 +179,7 @@ private static function cloneAndVerifyRepo(
             preg_match(
               '@<(?<next>https://api.github.com[^>]+)>; rel="next"@',
               $header_line,
-              $matches,
+              &$matches,
             )
           ) {
             $url = $matches['next'];

src/shipit/ShipItShellCommand.php

@@ -117,7 +117,7 @@ private function runOnceSynchronously(): ShipItShellCommandResult {
     $fp = proc_open(
       $command,
       $fds,
-      $pipes,
+      &$pipes,
       $this->path,
       $env_vars->toArray(),
     );
@@ -155,9 +155,9 @@ private function runOnceSynchronously(): ShipItShellCommandResult {
       $ready_streams = [$stdout_stream, $stderr_stream];
       $null_byref = null;
       $result = stream_select(
-        $ready_streams,
-        /* write streams = */ $null_byref,
-        /* exception streams = */ $null_byref,
+        &$ready_streams,
+        /* write streams = */ &$null_byref,
+        /* exception streams = */ &$null_byref,
         /* timeout = */ null,
       );
       if ($result === false) {

src/shipit/ShipItUtil.php

@@ -50,7 +50,7 @@ public static function parsePatch(string $patch): Iterator<string> {
         preg_match(
           '/^@@ -\d+(,(?<minus_lines>\d+))? \+\d+(,(?<plus_lines>\d+))? @@/',
           $line,
-          $matches,
+          &$matches,
         )
       ) {
         $minus_lines = $matches['minus_lines'] ?? '';

src/shipit/filter/ShipItMentions.php

@@ -51,7 +51,7 @@ public static function getMentions(
     preg_match_all(
       self::MENTIONS_PATTERN,
       $changeset->getMessage(),
-      $matches,
+      &$matches,
       PREG_SET_ORDER,
     );
     return (new ImmSet(array_map($match ==> $match[1], $matches)));

src/shipit/filter/ShipItUserFilters.php

@@ -24,7 +24,7 @@ classname<ShipItUserInfo> $user_info,
       preg_match(
         $pattern,
         $changeset->getAuthor(),
-        $matches,
+        &$matches,
       )
       && array_key_exists('user', $matches)
     ) {
@@ -85,7 +85,7 @@ public static function rewriteAuthorFromMessagePattern(
     string $pattern,
   ): ShipItChangeset {
     $matches = [];
-    if (preg_match($pattern, $changeset->getMessage(), $matches)) {
+    if (preg_match($pattern, $changeset->getMessage(), &$matches)) {
       return $changeset->withAuthor($matches['author']);
     }
     return $changeset;

src/shipit/phase/ShipItPhaseRunner.php

@@ -249,7 +249,7 @@ protected static function printHelp(
 
       $rows[$long] = tuple($left, $description);
     }
-    ksort($rows);
+    ksort(&$rows);
 
     $help = $rows['help'];
     $rows->removeKey('help');

src/shipit/repo/ShipItRepo.php

@@ -142,7 +142,11 @@ public static function open(
   protected static function parseDiffHunk(string $hunk): ?ShipItDiff {
     list($header, $body) = explode("\n", $hunk, 2);
     $matches = array();
-    preg_match('@^diff --git [ab]/(.*?) [ab]/(.*?)$@', trim($header), $matches);
+    preg_match(
+      '@^diff --git [ab]/(.*?) [ab]/(.*?)$@',
+      trim($header),
+      &$matches,
+    );
     if (count($matches) === 0) {
       return null;
     }

src/shipit/repo/ShipItRepoGIT.php

@@ -82,7 +82,7 @@ public function findLastSourceCommit(
       !preg_match(
         '/^ *(fb)?shipit-source-id: (?<commit>[a-z0-9]+)$/m',
         $log,
-        $matches,
+        &$matches,
       )
     ) {
       return null;
@@ -114,7 +114,7 @@ public function findNextCommit(
       return null;
     }
     $revs = explode("\n", trim($log));
-    list($rev) = explode(' ', array_pop($revs), 2);
+    list($rev) = explode(' ', array_pop(&$revs), 2);
     return $rev;
   }
 

src/shipit/repo/ShipItRepoHG.php

@@ -124,7 +124,7 @@ public function findLastSourceCommit(
       !preg_match(
         '/^ *fbshipit-source-id: (?<commit>[a-z0-9]+)$/m',
         $log,
-        $matches,
+        &$matches,
       )
     ) {
       return null;
@@ -297,7 +297,7 @@ private function getChangesetFromNativePatch(
     preg_match_all(
       '/^(?:rename|copy) (?:from|to) (?<files>.+)$/m',
       $patch,
-      $matches,
+      &$matches,
       PREG_PATTERN_ORDER,
     );
     $has_rename_or_copy = new ImmSet($matches['files']);