This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
fix sigpipe on osx #160
Merged
fix sigpipe on osx #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbalabanov-zz
approved these changes
Apr 1, 2019
|
Is there anything else I need to do on this PR? |
styurin
force-pushed
the
master
branch
2 times, most recently
from
495eff8
to
948c51c
Compare
|
@sbalabanov is there anything else I need to do to get this merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite being ostensibly a part of POSIX, MSG_NOSIGNAL is not defined in Mac OS. This causes nailgun to intermittently raise SIGPIPE on that platform, which in turn makes nails sometimes return exit status 141 when they should succeed and return exit status 0. This was breaking my Mac OS build of https://github.com/kframework/k.
Here we make use of the alternative, OSX-specific API SO_NOSIGPIPE to fix the same problem. this has been tested against the K test suite and makes it pass on Mac OS X.