This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
Make the order of sub-dependencies deterministic. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| if (recursive) { | ||
| // doesn't block the return of this function invocation, but defers | ||
| // the resulution of collectionsInProgress.emptied.then(…) |
davidaurelio
force-pushed
the
make-dependency-order-deterministic
branch
2 times, most recently
from
e1404d0
to
df08704
Compare
This makes the order of dependencies deterministic, if modules have a common set of subdependencies.
In the dependency tree
```
├── a
│ ├── b
│ └── c
└── d
├── b
└── c
```
The order of dependencies did depend on whether `a` or `d` finished scanning their dependencies first.
It could either be `a, b, c, d` or `a, d, b, c`. This change guarantees a depth-first order, for this tree that would be `a, b, c, d`
davidaurelio
force-pushed
the
make-dependency-order-deterministic
branch
from
df08704
to
1fd11d1
Compare
davidaurelio
added a commit
that referenced
this pull request
Mar 17, 2016
Make the order of sub-dependencies deterministic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the order of dependencies deterministic, if modules have a common set of subdependencies.
In the dependency tree
The order of dependencies did depend on whether
aordfinished scanning their dependencies first.It could either be
a, b, c, dora, d, b, c. This change guarantees a depth-first order, for this tree that would bea, b, c, d