Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

nuclide-file-tree bugs #27

Closed
alicoding opened this issue Jun 3, 2015 · 5 comments
Closed

nuclide-file-tree bugs #27

alicoding opened this issue Jun 3, 2015 · 5 comments

Comments

@alicoding
Copy link

Hey guys!

First of all, thanks for the invitation and I'm happy to contribute and will do as much as I can.
I thought it'd be nice to file a meta bug for Nuclide's specific feature and reference them to any known bug, and I'm not sure if that's a good thing to do but if isn't the right workflow please feel free to close this bug and I will file a new bug for my issue that I've found.

  • Two file/directory tree on sidebar - Opening a folder? #3
  • Clicked on the item on the tree does not open the file right away (needs to double click to do so).
  • Clicked on the folder does not expand the item.

So I'm not sure if they are intentional there for the last two?

@ssorallen
Copy link
Contributor

Thanks for the issue.

The latter two are intentional in our file tree, but we are definitely interested in feedback. You can either expand a directory by clicking the arrow next to it or by first selecting the directory and then clicking again.

#3 is unintended, and we will look at merging the PR to prevent the second tree from displaying.

@enilsen16
Copy link

The popular file-icons package is also not supported by nuclide-file-tree.

@ssorallen
Copy link
Contributor

Thanks for pointing that out, @enilsen16. That package looks to be relying on the file tree using the icon-file-text icon for all file types, but Nuclide's tree does some file type customization already. I'll open a separate issue to track that.

@steve-rodrigue
Copy link

I too have 2 file/directory tree like mentioned above

Ill update when you guys provide a patch. I'm very with nuclide so far, thanks!

@ssorallen
Copy link
Contributor

'nuclide-file-tree' now permanently disables Atom's 'tree-view' package. If you disable 'nuclide-file-tree' via Atom's Settings view, 'nuclide-file-tree' will re-enable 'tree-view' (https://github.com/facebook/nuclide/blob/master/pkg/nuclide/file-tree/lib/main.js#L153). If you run Atom in safe mode you will have to manually re-enable 'tree-view' or remove it from disabledPackages in ~/.atom/config.cson.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants