This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2k
[4.1] HttpClients rework #181
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
For me, it doesn't make sense to technically be possible to call
getResponseHeaders()
orgetResponseHttpStatusCode()
before a call tosend()
. (because they're public)I propose to only have a
send()
method inFacebookHttpClientInterface
that take headers in arguments (something like @SammyK did in #169) but instead returns the raw body, returns an array with the raw body, the status code and response header, because theses data are linked together.This will also ease tests of the coming
FacebookClient
:)@gfosco, @SammyK any thoughts ?
The text was updated successfully, but these errors were encountered: