Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

[4.1] HttpClients rework #181

Closed
yguedidi opened this issue Aug 2, 2014 · 6 comments
Closed

[4.1] HttpClients rework #181

yguedidi opened this issue Aug 2, 2014 · 6 comments

Comments

@yguedidi
Copy link
Contributor

yguedidi commented Aug 2, 2014

For me, it doesn't make sense to technically be possible to call getResponseHeaders() or getResponseHttpStatusCode() before a call to send(). (because they're public)
I propose to only have a send() method in FacebookHttpClientInterface that take headers in arguments (something like @SammyK did in #169) but instead returns the raw body, returns an array with the raw body, the status code and response header, because theses data are linked together.
This will also ease tests of the coming FacebookClient :)

@gfosco, @SammyK any thoughts ?

@SammyK
Copy link
Contributor

SammyK commented Aug 4, 2014

Makes sense to me. If #169 gets pulled it this could be a nice update.

@gfosco
Copy link
Contributor

gfosco commented Aug 12, 2014

Sure.

@SammyK
Copy link
Contributor

SammyK commented Aug 21, 2014

I also like how you sent in the FacebookRequest entity as the only argument in send().

@yguedidi
Copy link
Contributor Author

I'll work on it as soon as possible ;)

@SammyK
Copy link
Contributor

SammyK commented Jan 28, 2015

Hey @yguedidi! All this stuff has been reworked so I think we can close this one too?

@yguedidi
Copy link
Contributor Author

Yes!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants