Dropping the -v4
suffix from the repo & Packagist
#638
Comments
Looks good to me :) |
But I'd suggest |
Yeah, that's a good idea since that would disambiguate it from the ads SDK and any other PHP SDK's @ Facebook. Ping @viv001 :) |
Sounds good guys! I will have a look on Monday and follow up on this thread :) |
Sweet - thanks @viv001!
It's just to remove some redundancy. Packagist only hosts php packages so there's no need for the prefix. :) |
@SammyK the process of updating is indeed right. |
Thanks @stof! :) Perhaps we could rename the repo to match the name on Packagist but with a Packagist: |
Looks good to me |
Update: Changed the github repo name |
Yay! Thanks @viv001! :) |
Changing the repo name to php-graph-sdk as discussed in #638
Yes! Works perfectly on my tests! Once @yguedidi confirms, we can close this one out. :) @viv001 One more quick suggestion. The the old Can we update this one on Packagist to point to the new package as well? :) |
Done :) |
Looks good! We finally remove it!! :) |
Let's finally knock out the conversation that started way back in #411 and drop the
-v4
from this repo name and Packagist. It's causing a lot of confusion with devs learning the Facebook PHP SDK for the first time so it'll be good to finally fix this. :)We'll need help from Vivek on this one, but step one would be rename the repo in GitHub then point Packagist to the new repo name. Vivek: Here's the direct edit link on Packagist.
Then we can discuss renaming the package on Packagist to
facebook/sdk
. I believe this is done by abandoningfacebook/php-sdk-v4
and updating the name incomposer.json
tofacebook/sdk
and resubmitting. @yguedidi @stof Is that right?The text was updated successfully, but these errors were encountered: