Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Incompatible with most recent node version? #2520

Closed
ghost opened this issue Aug 31, 2018 · 4 comments
Closed

Incompatible with most recent node version? #2520

ghost opened this issue Aug 31, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Aug 31, 2018

Installing prepack on a recent node version (I tried v10.9.0 on a 4.18.5-arch1-1-ARCH Linux machine) fails; downgrading my node is, in my case, not an option.

I'm hit with the same error that was brought to our attention by @rpkoller back in June, and am afraid that v8-profiler, the dependency whose installation appears to be the cause of this issue, shows some maintenance issues.

They don't support node > 7 and seem to have had their last release over a year ago. Numerous issues were opened regarding this:

but none of them have been addressed.

Is there anything you can do about this?

@hermanventer
Copy link
Contributor

Is there another profiler with better support?

@ghost
Copy link
Author

ghost commented Aug 31, 2018

The v8 profiler in and of itself is fine; it's just the (seemingly unofficial?) node bindings that are causing these issues, i.e. the v8-profiler package.

Is there another profiler with better support?

I would reckon so. I just stumbled upon v8-profiler-node8, which (despite of its name) claims to also support node 10.x.

I tried to install it on my machine, and it built just fine. Maybe you could experiment with substituting the node bindings and see if it also works with your test matrix?

@hermanventer
Copy link
Contributor

Great to hear. If you would like to put a pull request to do the substitution I would be happy to test it locally.

facebook-github-bot pushed a commit that referenced this issue Sep 7, 2018
Summary:
This commit addresses issue #2520. In brief, `v8-profiler` fails to build on recent node versions.
Pull Request resolved: #2525

Reviewed By: hermanventer

Differential Revision: D9689106

Pulled By: NTillmann

fbshipit-source-id: 9169321bdc23dfbfdf24b50fe7885dab36c5322e
@NTillmann
Copy link
Contributor

Fix has landed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants