This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Don't generate redundant calls to query captured scopes #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,16 @@ | |||
| // add at runtime:var a = 17; | |||
| // Copies of \|\|:2 | |||
There was a problem hiding this comment.
I expected this to 1 copy.
There was a problem hiding this comment.
It's two. The closure is accessed from the optimized function, and the inspect function. But not more!
hermanventer
approved these changes
Apr 12, 2018
There was a problem hiding this comment.
@NTillmann is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
trueadm
pushed a commit
to trueadm/prepack
that referenced
this pull request
Apr 13, 2018
Summary: Release notes: None Don't generate redundant calls of the form `var __captured__scope_2 = __scope_0[0] || __scope_1(0);` Adding regression test. This addresses one of the observations of facebookarchive#1732. Also deleted unneeded left-over code and comment that used to refer facebookarchive#989. Closes facebookarchive#1734 Differential Revision: D7602949 Pulled By: NTillmann fbshipit-source-id: 77d926b236a903eb7927a1471411e8397a0d192a
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: None
Don't generate redundant calls of the form
var __captured__scope_2 = __scope_0[0] || __scope_1(0);Adding regression test.
This addresses one of the observations of #1732.
Also deleted unneeded left-over code and comment that used to refer #989.