OkHttp3 Interceptor crash #346

juandiana · 2016-01-27T14:08:00Z

I just upgraded OkHttp to version 3.0.1 and Stetho to version 1.3.0 (and its corresponding new OkHttp3 network interceptor).

I'm experiencing the following NullPointerException when inspecting HTTP traffic:

E/stetho: com.facebook.stetho.inspector.elements.android.DialogFragmentDescriptor.getChildren() emitted a null child at position 0 for element LayoutFragment{3a8b2dd3 #0 id=0x7f0c00dc}
E/AndroidRuntime: FATAL EXCEPTION: OkHttp Dispatcher
         Process: com.artech.androidbasictest.testgxsalto, PID: 29855
         java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Object.hashCode()' on a null object reference
         at com.facebook.stetho.okhttp3.StethoInterceptor$OkHttpInspectorResponse.connectionId(StethoInterceptor.java:229)
         at com.facebook.stetho.inspector.network.NetworkEventReporterImpl.responseHeadersReceived(NetworkEventReporterImpl.java:143)
         at com.facebook.stetho.okhttp3.StethoInterceptor.intercept(StethoInterceptor.java:73)
         at okhttp3.internal.http.HttpEngine$NetworkInterceptorChain.proceed(HttpEngine.java:681)
         at okhttp3.internal.http.HttpEngine.readResponse(HttpEngine.java:563)
         at okhttp3.RealCall.getResponse(RealCall.java:241)
         at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:198)
         at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:160)
         at okhttp3.RealCall.access$100(RealCall.java:30)
         at okhttp3.RealCall$AsyncCall.execute(RealCall.java:127)
         at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:33)
         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
         at java.lang.Thread.run(Thread.java:818)

The text was updated successfully, but these errors were encountered:

jasta · 2016-01-27T18:44:44Z

This looks like the same issue as with okhttp2, you may have accidentally used a regular interceptor instead of a network interceptor. I keep forgetting to actually fix this with a proper error message :(

juandiana · 2016-01-27T19:56:28Z

I did notice that there are two methods for adding an interceptor when building an OkHttpClient instance. Notice that I actually used the addNetworkInterceptor method, as follows:

mHttpClient = new OkHttpClient.Builder()
        .connectTimeout(CONNECT_TIMEOUT, TimeUnit.SECONDS)
        .readTimeout(READ_TIMEOUT, TimeUnit.SECONDS)
        .addNetworkInterceptor(new StethoInterceptor())
        .build();

jasta · 2016-01-27T20:04:06Z

Hmm, then I'm puzzled. @swankjesse?

swankjesse · 2016-01-27T23:28:57Z

The interceptor might be returning a null connection after that physical connection has been released back to the pool. Perhaps the response has a Connection: close header and the response body is empty? Regardless the fix is pretty easy. I should fix OkHttp to keep a reference to the connection while the interceptor is run so this doesn’t happen.

kypeli · 2016-03-08T13:46:21Z

I am facing the same crash here.

    compile 'com.squareup.okhttp3:okhttp:3.2.0'
    compile 'com.facebook.stetho:stetho:1.3.1'
    compile 'com.facebook.stetho:stetho-okhttp3:1.3.1'

Please note that since OkHttp3, you can't add the interceptor with client.networkInterceptors().add(new StethoInterceptor()) because OkHttp3 is immutable. So you have to use the Builder approach.

Could the crash be related to this?

My device is connected since I can use Vysor and debug the app through the same connection, so it's not a connection issue.

jasta · 2016-03-08T16:43:01Z

@kypeli your crash is unrelated.

kypeli · 2016-03-08T18:08:05Z

@jasta Thanks for the clarification. I see the same stack trace or null pointer exception, so must be the same issue as described in this ticket. Hopefully fixed soon :)

dave-r12 · 2016-03-14T12:08:52Z

Hello, we've merged in a change that should resolve this that will be going out with OkHttp 3.3.

baurine · 2016-03-26T15:27:35Z

I also face the same crash:

java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Object.hashCode()' on a null object reference
    at com.facebook.stetho.okhttp3.StethoInterceptor$OkHttpInspectorResponse.connectionId(StethoInterceptor.java:229)
    at com.facebook.stetho.inspector.network.NetworkEventReporterImpl.responseHeadersReceived(NetworkEventReporterImpl.java:143)
    at com.facebook.stetho.okhttp3.StethoInterceptor.intercept(StethoInterceptor.java:73)
    at okhttp3.internal.http.HttpEngine$NetworkInterceptorChain.proceed(HttpEngine.java:681)
    at okhttp3.internal.http.HttpEngine.readResponse(HttpEngine.java:563)
    at okhttp3.RealCall.getResponse(RealCall.java:241)
    at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:198)
    at cn.pyromusic.pyro.api.RestClient$1.intercept(RestClient.java:69)
    at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:187)
    at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:160)
    at okhttp3.RealCall.access$100(RealCall.java:30)
    at okhttp3.RealCall$AsyncCall.execute(RealCall.java:127)
    at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1112)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:587)
    at java.lang.Thread.run(Thread.java:818)

It happens when a http request returns 204 and has no response body.

I debuged, as above said, it was caused by null connection().

I use stetho 1.3.1 and retrofit 2.0 (it depends okhttp 3.2.0)

jasta · 2016-04-13T19:02:50Z

@baurine can you test with okhttp 3.3 to verify that the upstream fix works? I don't think this is necessarily a Stetho issue.

forzajuve · 2016-04-15T08:31:33Z

java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Object.hashCode()' on a null object reference
at com.facebook.stetho.okhttp3.StethoInterceptor$OkHttpInspectorResponse.connectionId(StethoInterceptor.java:229)
at com.facebook.stetho.inspector.network.NetworkEventReporterImpl.responseHeadersReceived(NetworkEventReporterImpl.java:143)
at com.facebook.stetho.okhttp3.StethoInterceptor.intercept(StethoInterceptor.java:73)
at okhttp3.internal.http.HttpEngine$NetworkInterceptorChain.proceed(HttpEngine.java:681)
at com.youku.laifeng.libcuteroom.http.LFHttpClient$LFInterceptor.intercept(LFHttpClient.java:1311)
at okhttp3.internal.http.HttpEngine$NetworkInterceptorChain.proceed(HttpEngine.java:681)
at okhttp3.internal.http.HttpEngine.readResponse(HttpEngine.java:563)
at okhttp3.RealCall.getResponse(RealCall.java:241)
at okhttp3.RealCall$ApplicationInterceptorChain.proceed(RealCall.java:198)
at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:160)
at okhttp3.RealCall.access$100(RealCall.java:30)
at okhttp3.RealCall$AsyncCall.execute(RealCall.java:127)
at okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
at java.lang.Thread.run(Thread.java:818)

compile 'com.facebook.stetho:stetho:1.3.1'
compile 'com.facebook.stetho:stetho-okhttp3:1.3.1'

OkHttpClient.Builder builder = new OkHttpClient.Builder();
builder.connectTimeout(CONNECT_TIME_OUT, TimeUnit.SECONDS);
builder.writeTimeout(WRITE_TIME_OUT, TimeUnit.SECONDS);
builder.readTimeout(READ_TIME_OUT, TimeUnit.SECONDS);
builder.networkInterceptors().add(new StethoInterceptor());
mOkHttpClient = builder.build();

Baleizao · 2016-04-16T10:20:16Z

@jasta I have the same problem and did some digging. The source of the crash is that okhttp3.RealCall.connection() always returns null. This is its current source code in master:

public Connection connection() {
  return null;
}

The fix that @swankjesse made for #2288 fixes the crash that @baurine saw but doesn't fix the case of okhttp3.RealCall being used.

I also noticed that we only need the connection object to compute a hash code that will become the connection ID, so maybe we don't even need a reference to the connection in the first place. Is there a chance we can replace it by something else (e.g. a counter or some random number)?

swankjesse · 2016-04-16T16:52:53Z

Yikes. I’ll fix this one too.

swankjesse · 2016-04-16T16:53:43Z

(Or more specifically, I’ll ask @dave-r12 to fix it!)

dave-r12 · 2016-04-17T00:00:41Z

@Baleizao I do not see that RealCall has a connection() method. I think you might be referring to the ApplicationInterceptorChain class? That class handles Application interceptors, which are different than network interceptors (see https://github.com/square/okhttp/wiki/Interceptors). Stetho is using a network interceptor, so that class should not matter.

Baleizao · 2016-04-17T08:14:18Z

Gah... you're absolutely right! I accidentally installed the StethoInterceptor as an application interceptor instead of as a network interceptor, hence the crash. Sorry folks! All sorted now.

baiiu · 2016-05-17T08:38:35Z

Yes, it is. it is worked by using addNetworkInterceptor method.

baurine · 2016-05-22T03:29:14Z

@jasta so so sorry, I just remember the thing you asked me to do. but I can't find okhttp 3.3, the latest version is still 3.2.0. I tried compile 'com.squareup.okhttp3:okhttp:3.3.0-SNAPSHOT', but gradle tell me Failed to resolve: com.squareup.okhttp3:okhttp:3.3.0-SNAPSHOT. I read the above comments, it seems this bug has already fixed, right?

@baurine can you test with okhttp 3.3 to verify that the upstream fix works? I don't think this is necessarily a Stetho issue.

One more thing, I updated the android studio from 1.5 to 2.1 stable, debug my project again, and this bug didn't reproduce, I tried many times. It is a little strange.

juandiana · 2016-05-22T07:07:54Z

@baurine According to OkHttp's README:

Snapshots of the development version are available in Sonatype's snapshots repository.

So, you just need to add the repository url to your gradle script repositories section.

repositories {
    ...
    maven {
        url "https://oss.sonatype.org/content/repositories/snapshots"
    }
}

baurine · 2016-05-23T02:16:49Z

@juandiana thank you! it works. Now I used the okhttp 3.3, test again, the crash has not happened again. but my develop environment is not as same as before, I updated the android studio from 1.5 to 2.1. any way, if I meet this bug again, I will report.

jasta · 2016-06-02T03:49:23Z

Can this issue be closed out? It looks like the thread has settled a bit and okhttp 3.3 is indeed confirmed to fix, yes?

fzymek · 2016-11-30T12:26:56Z

I was using okhttp as transitive dependency from retrofit2 and this crash happened to me as well. After including direct dependency to okhttp:3.4.2 it is no longer happening.

cristan · 2017-10-11T16:34:51Z

A null check has been committed on master, but no release has been made after 1.5.0 yet.

ghost · 2017-11-06T15:23:02Z

When are we expecting the null check on master to be updated into a 1.5.1 release? We're blocked using stetho's network feature because of the crash fixed with @cristan's commit.

naturalwarren · 2017-11-06T15:52:04Z

Is your interceptor registered as a network interceptor? #549 provides a better error message when you're incorrectly registered as a vanilla interceptor.

jasta · 2018-01-02T20:54:17Z

We don't actually want folks using StethoInterceptor as an app interceptor (instead of a network interceptor), so we've gone further and are now just throiwng a clear error message to this effect. See #584.

anjinlu · 2018-07-24T23:02:51Z

App Crashes when the request is cancelled and the interceptor return NULL.

In my code, "Cancelled" exception was caught, return NULL or re-throw the exception cause the app crash.

public class HttpInterceptor : Java.Lang.Object, IInterceptor {
	public Response Intercept(IInterceptorChain chain) {
		Response response = null;
		try {
			Request request = chain.Request();
			response = chain.Proceed(request);
		} catch (Exception e) {
		}
		return response;
	}
}

swankjesse mentioned this issue Jan 27, 2016

Network interceptor connection() might be null square/okhttp#2288

Closed

wph95 mentioned this issue Jul 6, 2016

[Bug] com.qiniu.http.Client throw NullPointerException qiniu/java-sdk#214

Closed

naturalwarren mentioned this issue Aug 3, 2017

Throw RegistrationException when connection isn't present. #549

Closed

jasta closed this as completed Jan 2, 2018

yura-f mentioned this issue Jan 18, 2019

YandexMetrica + Stetho = java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.Object.hashCode()' on a null object reference yandexmobile/metrica-sample-android#38

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OkHttp3 Interceptor crash #346

OkHttp3 Interceptor crash #346

juandiana commented Jan 27, 2016

jasta commented Jan 27, 2016

juandiana commented Jan 27, 2016

jasta commented Jan 27, 2016

swankjesse commented Jan 27, 2016

kypeli commented Mar 8, 2016

jasta commented Mar 8, 2016

kypeli commented Mar 8, 2016

dave-r12 commented Mar 14, 2016

baurine commented Mar 26, 2016

jasta commented Apr 13, 2016

forzajuve commented Apr 15, 2016

Baleizao commented Apr 16, 2016

swankjesse commented Apr 16, 2016

swankjesse commented Apr 16, 2016

dave-r12 commented Apr 17, 2016

Baleizao commented Apr 17, 2016

baiiu commented May 17, 2016 •

edited

baurine commented May 22, 2016 •

edited

juandiana commented May 22, 2016

baurine commented May 23, 2016

jasta commented Jun 2, 2016

fzymek commented Nov 30, 2016

cristan commented Oct 11, 2017

ghost commented Nov 6, 2017

naturalwarren commented Nov 6, 2017

jasta commented Jan 2, 2018

anjinlu commented Jul 24, 2018

OkHttp3 Interceptor crash #346

OkHttp3 Interceptor crash #346

Comments

juandiana commented Jan 27, 2016

jasta commented Jan 27, 2016

juandiana commented Jan 27, 2016

jasta commented Jan 27, 2016

swankjesse commented Jan 27, 2016

kypeli commented Mar 8, 2016

jasta commented Mar 8, 2016

kypeli commented Mar 8, 2016

dave-r12 commented Mar 14, 2016

baurine commented Mar 26, 2016

jasta commented Apr 13, 2016

forzajuve commented Apr 15, 2016

Baleizao commented Apr 16, 2016

swankjesse commented Apr 16, 2016

swankjesse commented Apr 16, 2016

dave-r12 commented Apr 17, 2016

Baleizao commented Apr 17, 2016

baiiu commented May 17, 2016 • edited

baurine commented May 22, 2016 • edited

juandiana commented May 22, 2016

baurine commented May 23, 2016

jasta commented Jun 2, 2016

fzymek commented Nov 30, 2016

cristan commented Oct 11, 2017

ghost commented Nov 6, 2017

naturalwarren commented Nov 6, 2017

jasta commented Jan 2, 2018

anjinlu commented Jul 24, 2018

baiiu commented May 17, 2016 •

edited

baurine commented May 22, 2016 •

edited