Skip to content
This repository has been archived by the owner on May 1, 2023. It is now read-only.

Provide a better customization API for Stetho.initialize #234

Merged
merged 2 commits into from Aug 10, 2015

Conversation

jasta
Copy link
Contributor

@jasta jasta commented Jul 21, 2015

Now that many more configuration options are becoming available it's
important to provide a more streamlined API for overriding plugins or
adding new ones, especially for dumpapp.

Closes #195

Now that many more configuration options are becoming available it's
important to provide a more streamlined API for overriding plugins or
adding new ones, especially for dumpapp.

Closes facebookarchive#195
@jasta
Copy link
Contributor Author

jasta commented Jul 29, 2015

@rightparen I actually took a look at doing it using a Map per your out-of-band suggestion but I honestly think this approach is still better. It's more concise and doesn't require callers to repeat the name of the plugin in two places (one in registration and one in the plugin itself). Technically that can be modified so the plugin no longer self identifies but since this is not ABI compatible it cannot be done quickly.

Also I noticed that the flexibility desired by your approach is still possibly by simply manipulating this design and saying new DefaultDumperPluginsBuilder(...).build(), yielding a list which can be trivially converted to a map yourself. Few callers would need this, however, but it is important to observe that it is still possible.

@jasta jasta added this to the v1.2.0 milestone Aug 4, 2015
jasta added a commit that referenced this pull request Aug 10, 2015
Provide a better customization API for Stetho.initialize
@jasta jasta merged commit 7f86e20 into facebookarchive:master Aug 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants