This repository has been archived by the owner on May 1, 2023. It is now read-only.
Added a way to provide the database files to the DatabasePeerManager module. #91
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
stetho/src/main/java/com/facebook/stetho/inspector/database/DatabaseFilesProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.facebook.stetho.inspector.database; | ||
|
||
import java.io.File; | ||
import java.util.List; | ||
|
||
/** | ||
* Provides a {@link List} of database files. | ||
*/ | ||
public interface DatabaseFilesProvider { | ||
|
||
/** | ||
* Returns a {@link List} of database files. | ||
*/ | ||
List<File> getDatabaseFiles(); | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
...ho/src/main/java/com/facebook/stetho/inspector/database/DefaultDatabaseFilesProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
package com.facebook.stetho.inspector.database; | ||
|
||
import android.content.Context; | ||
import java.io.File; | ||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
/** | ||
* Provides the results of {@link Context#databaseList()}. | ||
*/ | ||
public final class DefaultDatabaseFilesProvider implements DatabaseFilesProvider { | ||
|
||
private final Context mContext; | ||
|
||
public DefaultDatabaseFilesProvider(Context context) { | ||
mContext = context; | ||
} | ||
|
||
@Override | ||
public List<File> getDatabaseFiles() { | ||
List<File> databaseFiles = new ArrayList<File>(); | ||
for (String filename : mContext.databaseList()) { | ||
databaseFiles.add(new File(filename)); | ||
} | ||
return databaseFiles; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: new line; mark
databaseFilesProvider
with@Nullable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, mark
mDatabaseFilesProvider
with@Nullable
and then make things not crash if it's null. Or drop this null support :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll drop the null support. Originally the
DatabaseFilesProvider
was optional and added to thecontext.databaseList()
. I forgot to remove the comments once that interface became the only thing providing the file names.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure where you want to the new line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, misread :)