This repository has been archived by the owner on Oct 15, 2019. It is now read-only.
Upgrade to Guice 4 and Java 8 #250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you switch Swift to Airbase?
|
|
Shouldn't we wait until 4 is final at least? What is the benefit to doing this now (while 4 is still beta)? |
|
Guice 3 fails on Java 8 if there is an error: google/guice#757 Guice 4 has been in beta for over a year and seems to be widely used. |
|
Guice 4 has been in beta since 7/31/2013 (It has historically move really slowly). At this point, I believe "beta" just means "APIs may change without notice", rather than a reflection of how robust it is. |
|
Cool |
|
Ok, updated to use airbase, @electrum |
|
merged & pushed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.