-
Notifications
You must be signed in to change notification settings - Fork 110
error when build thpp,wuwuwu,I‘m so sad! #44
Comments
Your compiler is complaining about a modern feature. Is your compiler up to date? More information about your build environment would be useful. |
I don't know what you exactly mean, I copy the more info, can you help me? @Endofunctor
|
I see your compiler is GNU GCC 5.4.0. In your local repo can you edit this file: Pull request #32 is exactly this change. |
I solved the error with your help, but I meet a new error: I had installed the thrift... I'm so sorry to bother you, but I really have no idea..thank you so much~@Endofunctor |
I am encountering error at this same step, where after changing the
|
Figured out the problems, basically use pull request number 32 and 42 are needed to compile thpp. I also used older versions of folly and other libraries that were the latest versions that were compatible with
|
You had install all of these successfully? I want to run crnn project, but I cant install thpp... @se4u |
@zoe218 Hi, yes I installed all of these successfully. Basically what's going on is that the api in these open source libraries has changed subtly with C++14. For example, you said that you got the following error:
This error is probably because of some error in the macro, or because the THTensor_prod function was meant to be doing inplace operation and returning void and it was changed to return the handle of the new tensor. Since all these libraries are not compatible at this point of time, and the repo maintainers have not yet merged the pull requests for fixing this, you could just merge these pull requests directly in your own fork yourself and also you could use older versions of the libraries that are known to work. |
我也是想运行crnn的时候,安装thpp出错,请问你解决了么 @zoe218 |
@mengya22 没有啊,你是什么错? |
@zoe218 和你差不多,是因为torch版本和thpp不兼容么? |
@zoe218 I tried @se4u 's recipe but still got errors on thpp compilation. Later I figured out the solution: use the patched version by CodeVerySlow: You can clone the code by After that you need to change CMakeLists.txt:45: If the compiler complains about undefined 'FOLLY_MAYBE_UNUSED', you need to add an include file in the beginning of 'build/thpp/if/gen-cpp2/Tensor_types.h': |
你现在安装好了么 @mengya22 |
I did this change via pull requests 10 months ago, but is not accepted... |
@zoe218 你们的文件夹有thpp/cmake里面FindTorch.cmake这个文件么,我cmake 一直报错,说没有这个文件无法find torch |
[ 10%] Building CXX object CMakeFiles/thpp.dir/Storage.cpp.o
In file included from /tmp/fblualib-build.uR4GKO/thpp/thpp/build/thpp/if/gen-cpp2/Tensor_types.h:13:0,
from /tmp/fblualib-build.uR4GKO/thpp/thpp/../thpp/Storage.h:22,
from /tmp/fblualib-build.uR4GKO/thpp/thpp/Storage.cpp:11:
/usr/local/include/folly/io/Cursor.h: In member function ‘size_t folly::io::detail::CursorBase<Derived, BufType>::cloneAtMost(std::unique_ptrfolly::IOBuf&, size_t)’:
/usr/local/include/folly/io/Cursor.h:443:13: error: ‘make_unique’ is not a member of ‘std’
buf = std::make_uniquefolly::IOBuf();
^
/usr/local/include/folly/io/Cursor.h:443:13: note: suggested alternative:
In file included from /usr/local/include/thrift/lib/cpp/Thrift.h:23:0,
from /usr/local/include/thrift/lib/cpp2/Thrift.h:20,
from /tmp/fblualib-build.uR4GKO/thpp/thpp/build/thpp/if/gen-cpp2/Tensor_types.h:9,
from /tmp/fblualib-build.uR4GKO/thpp/thpp/../thpp/Storage.h:22,
from /tmp/fblualib-build.uR4GKO/thpp/thpp/Storage.cpp:11:
/usr/local/include/folly/Memory.h:63:1: note: ‘folly::make_unique’
make_unique(Args&&...) = delete;
^
In file included from /tmp/fblualib-build.uR4GKO/thpp/thpp/build/thpp/if/gen-cpp2/Tensor_types.h:13:0,
from /tmp/fblualib-build.uR4GKO/thpp/thpp/../thpp/Storage.h:22,
from /tmp/fblualib-build.uR4GKO/thpp/thpp/Storage.cpp:11:
/usr/local/include/folly/io/Cursor.h:443:42: error: expected primary-expression before ‘>’ token
buf = std::make_uniquefolly::IOBuf();
^
/usr/local/include/folly/io/Cursor.h:443:44: error: expected primary-expression before ‘)’ token
buf = std::make_uniquefolly::IOBuf();
^
CMakeFiles/thpp.dir/build.make:84: recipe for target 'CMakeFiles/thpp.dir/Storage.cpp.o' failed
make[2]: *** [CMakeFiles/thpp.dir/Storage.cpp.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/thpp.dir/all' failed
make[1]: *** [CMakeFiles/thpp.dir/all] Error 2
Makefile:138: recipe for target 'all' failed
make: *** [all] Error 2
The text was updated successfully, but these errors were encountered: