iOS 5 ipad compatibility issues

[aporat]

this pull request includes some changes to TTBaseController which solves the issues with UIPopViewController & TTSplitViewController under iOS 5.

The parentViewController function role was under with iOS 5 (http://omegadelta.net/2011/11/04/oh-my-god-they-killed-parentviewcontroller/) which caused issues with TTSplitViewController when the secondary view controller is displayed as a popup view controller.

closes #713

[tonklon]

Ugh, a lot of cosmetic changes between real fixes. IMHO cosmetics should have their own commit(s).

[aporat]

also including #719 bug fix here

[aporat]

As I'm no longer using the TTNavigator and the url mapping, I'm not planning on looking at it.
Either merge it as is or close this pull request. as far as i know, these changes work well.

[shenwill]

A quick fix in TTBaseNavigator.m.
From iOS 5, [uiViewController parentViewController] returns its containing view controller only, no longer returns the presenting view controller (aka. model view controller, the presenter), or split view controller.

///////////////////////////////////////////////////////////////////////////////////////////////////
+ (TTBaseNavigator*)navigatorForView:(UIView*)view {
  // If this is called with a UIBarButtonItem, we can't traverse a view hierarchy to find the
  // navigator, return the global navigator as a fallback.
  if (![view isKindOfClass:[UIView class]]) {
    return [TTBaseNavigator globalNavigator];
  }

  id<TTNavigatorRootContainer>  container = nil;
  UIViewController*             controller = nil;      // The iterator.
  UIViewController*             childController = nil; // The last iterated controller.

  controller = view.viewController;
  while (nil != controller) {

    if ([controller conformsToProtocol:@protocol(TTNavigatorRootContainer)]) {
      container = (id<TTNavigatorRootContainer>)controller;
      break;
    }

    childController = controller;
    controller = childController.parentViewController;

    // From iOS 5, [uiViewController parentViewController] returns its containing view 
    // controller only, no longer returns the presenting view controller (aka. model view  
    // controller, the presenter), or split view controller.
    if (nil == controller
        && [childController respondsToSelector:@selector(presentingViewController)]) {
      controller = childController.presentingViewController;
    }

    if (nil == controller) {
      controller = childController.splitViewController;
    }
  }

  TTBaseNavigator* navigator = [container getNavigatorForController:childController];
  if (nil == navigator) {
    navigator = [TTBaseNavigator globalNavigator];
  }

  return navigator;
}

[jamesgpearce]

Facebook has not maintained or supported Three20 for some time, and we are closing its old and outstanding pull requests.

Many, many thanks for your support of the project. If you have any further questions, please don't hesitate to let me know.