This repository has been archived by the owner on Jan 13, 2022. It is now read-only.
[UI] Fix TTTextStyle shadow flipping bug #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about factoring out that check to one of the TTCore headers and use in in the various places? |
|
Yes that sounds like a good idea. |
|
Why not merging this in? |
|
That's a good question. Why did I close this. Let's re-open it and put it into next week's push. I must've thought I merged it in already. |
jwang
added a commit
that referenced
this pull request
Jul 23, 2011
…ping-bug [UI] Fix TTTextStyle shadow flipping bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This was originally submitted as part of the fixes in #307
To make it easier for you to merge it, it is now based off the facebook:development branch.
Thanks.