Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Add ordered parallel dataset iterator #2

Merged
merged 1 commit into from
Jun 27, 2016
Merged

Add ordered parallel dataset iterator #2

merged 1 commit into from
Jun 27, 2016

Conversation

anibali
Copy link
Contributor

@anibali anibali commented Jun 24, 2016

tnt.ParallelDatasetIterator does not guarantee order. Since there are situations where repeatable experiments are desirable, this PR proposes adding a new tnt.OrderedParallelDatasetIterator.

@lvdmaaten
Copy link
Contributor

This is a great idea!

I'm not sure if I'm happy with having a separate OrderedParallelDatasetIterator though, as it has a lot of copy-pasta from ParallelDatasetIterator. Why not add an optional input argument ordered (with default value false) to the constructor of ParallelDatasetIterator?

@anibali
Copy link
Contributor Author

anibali commented Jun 25, 2016

That's a fair point, there is a lot of copy-pasted code. I'll look into doing it in your proposed way after the weekend.

@anibali
Copy link
Contributor Author

anibali commented Jun 26, 2016

@lvdmaaten I've merged the code in with ParallelDatasetIterator. Let me know what you think.

@lvdmaaten
Copy link
Contributor

Looks good, thanks!

@lvdmaaten lvdmaaten merged commit b4b809f into facebookarchive:master Jun 27, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants