Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonicalize paths that bind to Offset/HeapBlock values #722

Merged
merged 1 commit into from Jan 8, 2021

Conversation

hermanventer
Copy link
Collaborator

Description

Treat Computed, HeapBlock and Offset paths more uniformly during canonicalization and elsewhere.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • API change with a documentation update
  • Additional test coverage
  • Code cleanup or just keeping up with the latest Rustc nightly

How Has This Been Tested?

./validate.sh
ran MIRAI over Libra

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 8, 2021
@hermanventer hermanventer requested a review from wrwg January 8, 2021 17:54
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #722 (bd245e7) into master (fbe6a2d) will increase coverage by 0%.
The diff coverage is 26%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #722   +/-   ##
======================================
  Coverage      41%     41%           
======================================
  Files          22      22           
  Lines       12605   12562   -43     
  Branches     5677    5630   -47     
======================================
+ Hits         5202    5207    +5     
+ Misses       3143    3128   -15     
+ Partials     4260    4227   -33     
Impacted Files Coverage Δ
checker/src/body_visitor.rs 34% <0%> (ø)
checker/src/call_visitor.rs 36% <0%> (ø)
checker/src/block_visitor.rs 40% <14%> (-1%) ⬇️
checker/src/abstract_value.rs 36% <50%> (+<1%) ⬆️
checker/src/path.rs 45% <62%> (+2%) ⬆️
checker/src/type_visitor.rs 57% <100%> (+<1%) ⬆️
checker/src/z3_solver.rs 46% <0%> (+<1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff90c71...bd245e7. Read the comment docs.

@hermanventer hermanventer merged commit 286c99b into master Jan 8, 2021
@hermanventer hermanventer deleted the offset branch January 8, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants