Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Did not retain recoil value on render, or committed after timeout elapsed. This is fine, but odd. undefined #1034

Closed
kvbalib opened this issue May 18, 2021 · 11 comments
Assignees

Comments

@kvbalib
Copy link

kvbalib commented May 18, 2021

I'm getting this error after React hot-reload, since I've updated Recoil to 0.3.0. I haven't noticed any issues in my app related to this, but console throws this every time. Don't know which part exactly is causing it, since it started after Recoil update, not in the development process.

I'm using latest create-react-app + react-app-rewired, RxJS, Recoil and Material UI.

@Svarto
Copy link

Svarto commented May 18, 2021

same here!

@CloudDrivenSolutions
Copy link

Also receiving the same error message. I rolled back to 0.2.0

@fultonm
Copy link

fultonm commented May 22, 2021

Just installed recoil ^0.3.1 and getting this issue after following a basic setup tutorial. Everything works but just getting this console error, so it seems fine I guess. Just odd.

@lejonmanen
Copy link

I can confirm this warning occurs in my simple "counter" project with create-react-app (with typescript) + recoil. Warning disappears if the page is reloaded. However, despite the message, the recoil state value is retained after hot reload. I'm guessing maybe recoil doesn't check for hot reloads.

@minhna
Copy link

minhna commented Jun 6, 2021

I have this issue with react native and expo, recoil 0.3.1

@drarmstr
Copy link
Contributor

drarmstr commented Jun 6, 2021

We investigated this and will be removing the warning. It should be safe to ignore. (cc @davidmccabe)

@snsie
Copy link

snsie commented Jun 7, 2021

I encountered this warning today after switching to the latest experimental version of react. Additionally, the state variable wasn't updating when using useRecoilState. Downgrading to an earlier experimental version of react/react-dom fixed the issue.

@davidmccabe
Copy link
Contributor

You can safely ignore this warning. Next point release will remove it. Sorry about this :(

@drarmstr drarmstr linked a pull request Jun 11, 2021 that will close this issue
@drarmstr
Copy link
Contributor

Removed in #1062

@shanoysinc
Copy link

stilling facing this error in 0.3.1 update

@drarmstr
Copy link
Contributor

stilling facing this error in 0.3.1 update

This was after 0.3.1, it's in nightly and expect it in the next release shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants