Remove unneeded logging #1062
Closed
Remove unneeded logging #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Remove a log now that our question about whether this actually happens is answered. This form of logging is much more intrusive in OSS where we don't have infra to gather stats on these, but just have to spew them to the console. Reviewed By: drarmstr Differential Revision: D28939979 fbshipit-source-id: 3e316825f4d49be8dffcccf4f9561d0c05b23406
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D28939979 |
|
This pull request has been merged in 4c37d94. |
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1062 Remove a log now that our question about whether this actually happens is answered. This form of logging is much more intrusive in OSS where we don't have infra to gather stats on these, but just have to spew them to the console. Reviewed By: drarmstr Differential Revision: D28939979 fbshipit-source-id: 465298b0bbc853b63bd8be97b47d9e222bd3b962
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1062 Remove a log now that our question about whether this actually happens is answered. This form of logging is much more intrusive in OSS where we don't have infra to gather stats on these, but just have to spew them to the console. Reviewed By: drarmstr Differential Revision: D28939979 fbshipit-source-id: 465298b0bbc853b63bd8be97b47d9e222bd3b962
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Remove a log now that our question about whether this actually happens is answered. This form of logging is much more intrusive in OSS where we don't have infra to gather stats on these, but just have to spew them to the console.
Reviewed By: drarmstr
Differential Revision: D28939979