Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/korean] Translate official document into Korean / except pages that alstn2468 translated #892

Closed
wants to merge 37 commits into from

Conversation

Mark-Yoo
Copy link

@Mark-Yoo Mark-Yoo commented Feb 19, 2021

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 19, 2021
@drarmstr drarmstr added the documentation Improvements or additions to documentation label Feb 23, 2021
@jung-han
Copy link

@Mark-Yoo
Hi. Are you working alone? If there is a part that has not been translated, I would like to help you out. How can I participate?

@Mark-Yoo
Copy link
Author

@jung-han Hi! Yes, I'm working alone now. I'm working on pages except alstn2468 translated. so basically Misc and Utils sections left. I would love to get some help from you if you are available. I'm actually working on atomFamliy.md, so whichever pages left are open for translation.

what you should do before contribute is to go register CLA
(See https://github.com/facebookexperimental/Recoil to follow the Contribution Guide)

@jung-han
Copy link

jung-han commented Feb 28, 2021

@Mark-Yoo
Good! I will work on a branch in the repository and review it.
If it's okay, can you give the repository collaborator authority?

(Maybe you're working on it..noWait() just translated.)

@Mark-Yoo
Copy link
Author

Mark-Yoo commented Mar 1, 2021

@jung-han You are invited as collaborator. Please keep on check which part you are working on and which part you finished translating 👍

@Mark-Yoo Mark-Yoo force-pushed the docs branch 2 times, most recently from 02b071e to 5ae9848 Compare March 1, 2021 11:37
@Mark-Yoo
Copy link
Author

@drarmstr I'll check what's new :)

@alstn2468
Copy link

@Mark-Yoo Thank you for finishing the remaining works :-)

@Mark-Yoo
Copy link
Author

@alstn2468 we've done what has to be done :) thanks you for all this translation to be started 👍

@drarmstr
Copy link
Contributor

We'd love to be able to merge these translations, but we don't yet have a link or index for the different translations from the documentation side. Would anyone here be interested in adding a link or tab on the main docs page to the translations so we can finally merge them?

@jung-han
Copy link

@drarmstr Can you give me some code to use as an example? It would be nice to let us know where it appears on the page.

@drarmstr
Copy link
Contributor

@jung-han - It doesn't appear anywhere right now... ;) We're hoping for some help if someone has time to investigate and do a PR for the docs branch to add the link and make a new page with the list of translations. Maybe putting the link in the footer would be the right place.

@Mark-Yoo
Copy link
Author

@drarmstr Hmm... We'll let you know if we find a way to do it. :) I've never tried make pages for the Official Page, so gotta find the way before I try :)

@alstn2468
Copy link

@Mark-Yoo I found the translation part in docusaurus document. It would be nice to see.

https://docusaurus.io/docs/en/translation

@Mark-Yoo
Copy link
Author

@alstn2468 Thanks! I'll read it :)

@drarmstr
Copy link
Contributor

Any luck with figuring out the right approach for publishing the translations @Mark-Yoo?

@Mark-Yoo
Copy link
Author

@drarmstr I'm working on urgent project now... so gonna need just a bit more time DX
sorry to drag...

@Mark-Yoo
Copy link
Author

@drarmstr I've read the page that @alstn2468 sent me and it was about using Crowdin to open the project for translation. Seems like the project has to be created upon Crowdin to get translators. Guess it's not the way we've been looking for... :(

I'm new to Docusaurus so probably need to figure out surfing internet or something.

I'm currently busy due to urgent project. Sorry being late and dragging...

@fguitton
Copy link

fguitton commented Apr 2, 2021

@Mark-Yoo, @drarmstr, @alstn2468. I'm just added the configuration for the FR repo based on Docusaurus docs. See my #377 (comment). No Crowdin required. Would that solution be workable ?

@Mark-Yoo
Copy link
Author

Mark-Yoo commented Apr 2, 2021

@fguitton I think that would be workable. Thanks! I'm just begin really busy, can't even focus reading Docusaurus documents... thanks for help! I really appreciate!

@alstn2468
Copy link

@Mark-Yoo If you're busy working, what can I do for you?
I don't know how it would be good to work because the PR that worked on the work was separated.

@ChobobDev
Copy link

@Mark-Yoo I can also give my hand for you.

@Mark-Yoo
Copy link
Author

Mark-Yoo commented Apr 2, 2021

@alstn2468 @ChobobDev Thanks guys! Guess it was my mistake separate PR from @alstn2468 . I'll combine my translations into @alstn2468 's PR to make things easier.

I'm currently reading Docusaurus Internationalization which is probably @fguitton refer to. Will you set the structure before I fork your repo, @alstn2468 ?

@alstn2468
Copy link

Okay, then I'll refer to #377(comment) and tell you after I finish setting it up at my fork repo.

@Mark-Yoo
Copy link
Author

Mark-Yoo commented Apr 2, 2021

@alstn2468 Thank you! I appreciate!

@alstn2468
Copy link

alstn2468 commented Apr 5, 2021

@Mark-Yoo @ChobobDev @jung-han

The internationalization setup was completed through the 36fa13c commit.
I have confirmed that the command yarn start -- --locale kr is executed normally.
I think the work to be carried out will be as follows.

  1. Combine separated PRs.
  2. Update missing translation, synchronizing the latest documents.
  3. Adding internationalized translation key data.

Can I add access to my forked repository?

image

@Mark-Yoo
Copy link
Author

Mark-Yoo commented Apr 5, 2021

@alstn2468 Nice! Please add me as collaborator so that I can make new PR's. Thanks for your work :)

@Mark-Yoo
Copy link
Author

Mark-Yoo commented Apr 5, 2021

@alstn2468 I've pushed and merged my parts :) should we wait @jung-han for his part?

@jung-han
Copy link

jung-han commented Apr 5, 2021

@Mark-Yoo @alstn2468
Can I put the translation file I was working on in that branch?
If right, i'll check it out in the evening and get it working.

@drarmstr
Copy link
Contributor

Sounds like all Korean translation has been merged into #18 and this PR can be closed.

@drarmstr
Copy link
Contributor

Duplicate of #18

@drarmstr drarmstr marked this as a duplicate of #18 Apr 14, 2021
@drarmstr drarmstr added the duplicate This issue or pull request already exists label Apr 14, 2021
@Mark-Yoo Mark-Yoo closed this Apr 14, 2021
@Mark-Yoo
Copy link
Author

This PR is now closed. All Korean translation merged into #18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation duplicate This issue or pull request already exists
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants