-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs/french] Translate official document to French #377
Conversation
fguitton
commented
Jun 22, 2020
•
edited
Loading
edited
- docs
- Introduction
- Motivation
- Core Concepts
- Installation
- Getting Started
- Basic Tutorial
- Intro
- Atoms
- Selectors
- Bonus: Performance (Didn't release)
- Guides
- Asynchronous Data Queries
- State Persistence
- API Reference
- Core
- atom()
- selector()
- isRecoilValue()
- Hooks
- useRecoilState()
- useRecoilValue()
- useSetRecoilState()()
- useResetRecoilState()()
- useRecoilValueLoadable()()
- useRecoilStateLoadable()()
- useRecoilCallback()()
- Utils
- atomFamily()
- selectorFamily()
- constSelector()
- errorSelector()
- noWait()
- waitForAll()
- waitForAny()
- waitForNone()
- Core
- Introduction
@fguitton - This PR is currently a "draft," what's your plan for wanting to merge? |
@drarmstr I'm going to proceed with translating what's left to translate in the coming few days, once that's done I'll be marking this ready for review. |
@drarmstr I believe I have completed the first treatment of the documentation including the latest changes from the |
@drarmstr, @Mark-Yoo, I have worked in the last commit (31076a5) on making things compile with the french Markdown. I realise now that the other pages will probably have to be dealt with differently, probably relying on the What are your thoughts ? |
@fguitton - Oh, this looks promising! looks like a single |
@drarmstr That's correct, everything gets built with a single Regarding what it will be for users, I am directly making use of the built-in locale selector : Recoil/docs/docusaurus.config.js Lines 69 to 72 in 3a76d01
And this yields the following screen: (I also noticed the latter had historical version documentation as well, something Recoil could leverage later ?) |
@fguitton How can we pass translation data in the |
@drarmstr, Yes, this is fully ready now It's a green light for me. I took the liberty to add the extra commit to translate the home ( |
@fguitton - The French translation is now live! Merci! |
* Create installation_kr.md and translated installation_kr to Korean * Seperate korean translation folder (docs/docs_kr) * Translate introduction/gettsing-started.mdx to Korean * Fix miss typo at docs/krgetting-started.mdx * Fix missing [] at getting-started.mdx -> CRA * Translate docs_kr/basic_tutorial/intro.md to Korean * Translate docs_kr/basic_tutorial/atoms.mdx * Remove english line at atoms.mdx * Remove english line at atoms.mdx * Fix miss typo at atoms.mdx * Fix miss typo at installation.d & gettig-started.mdx * Translate docs_kr/basic_tutorial/selectors.md * Fix miss typo at basic-tutorial/performance.md line 60 * Translate performace.md to Korean * Translate core-concepts to Korean * Fix core-concepts * Apply lately document from docs to docs_kr * Fix miss typo at docs_kr - performance section * [docs/kr] Translate introduction/motivation.md * Add installation ESLint docs korean verstion * Translate installation code block comment to Korean * Apply recent changes at selectors.md * Apply recent changes at installation.md * Translate api-reference/core/RecoilRoot.md * Translate sub title at RecoilRoot * Translate api-reference/core/atom * Translate api-reference/core/selector * Translate api-reference/core/isRecoilValue * Sync upstream docs to docs_kr * Sync installation.md * Sync atomFamily.md * Sync atom, guides and translate additional atom.md * Sync asynchronous-data-queries, testing, core-concepts * Fix typo in intro & performance * Init docusaurus i18n config * Fix locale kr -> ko * Translated: Snapshot.md is now translated into Korean * Translated: useGotoRecoilSnapshot.md is now translated into Korean * Translated: Lodable.md is now translated into Korean * Translated: useRecoilCallback.md is now translated into Korean * Translated: useRecoilSnapshot.md is now translated into Korean * Translated: useRecoilState.md is now translated into Korean * Translated: useRecoilStateLoadable.md is now translated into Korean * Translated: useRecoilTransactionObserver.md is now translated into Korean * Translated: useRecoilValue.md is now translated into Korean * Translated: useRecoilValueLoadable.md is now translated into Korean * Translated: useResetRecoilState.md is now translated into Korean * Translated: useSetRecoilState.md is now translated into Korean * Translated: asynchronous-data-queries.md is now translated into Korean * Translated: atom-effects.md is now translated into Korean * Translated: dev-tools.md is now translated into Korean * Translated: testing.md is now translated into Korean * Sync docs * Add useGetRecoilValueInfo.md to ko/api-reference/core * Translated: noWait.md is now translated into korean * Translated: waitForAny.md is now translated into korean * Translated: waitForAll.md is now translated into korean * Translated: waitForNone.md is now translated into korean * Translated: errorSelector.md is now translated into korean * Translated: constSelector.md is now translated into korean * Translated: selectorFamily.md is now translated into korean * Translated: useRecoilBridgeAcrossReactRoots.md is now translated into korean * Translated: atomFamily.md is now translated into korean * Add code.json korean translation * Add footer.json korean translation * Add navbar korean translation, fix core concepts title * Add remaining Korean translation data * Update docs/i18n/ko/code.json Co-authored-by: Asher Hwang <dev@hsh.kr> * Fix typo (시그니쳐 -> 시그니처) * Init index, resources page translation follow #377(ee54104) * index.js, resources 페이지 관련 번역 추가 Co-authored-by: Sungwoo Park <codest99@gmail.com> Co-authored-by: Mark Yoo <yjinhyuk@gmail.com> Co-authored-by: jung-han <hanjung@nhnent.com> Co-authored-by: Asher Hwang <dev@hsh.kr>