Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs/korean] Translate official document to Korean #18

Merged
merged 83 commits into from
Apr 19, 2021

Conversation

alstn2468
Copy link

@alstn2468 alstn2468 commented May 15, 2020

  • docs
    • Introduction
      • Motivation
      • Core Concepts
      • Installation
      • Getting Started
    • Basic Tutorial
      • Intro
      • Atoms
      • Selectors
      • Bonus: Performance (Didn't release)
    • Guides
      • Asynchronous Data Queries
      • Atom Effects
      • Testing
      • Dev Tools
    • API Reference
      • Core
        • <RecoilRoot />
        • State
          • atom()
          • selector()
          • Loadable
          • useRecoilState()
          • useRecoilValue()
          • useSetRecoilState()
          • useResetRecoilState()
          • useRecoilValueLoadable()
          • useRecoilStateLoadable()
          • useGetRecoilValueInfo()
          • isRecoilValue()
        • Snapshots
          • Snapshot
          • useRecoilTransactionObserver()
          • useRecoilSnapshot()
          • useGotoRecoilSnapshot()
        • useRecoilCallback()
        • Misc
          • useRecoilBridgeAcrossReactRoots()
      • Utils
        • atomFamily()
        • selectorFamily()
        • constSelector()
        • errorSelector()
        • waitForAll()
        • waitForAny()
        • waitForNone()
        • noWait()

@facebook-github-bot
Copy link
Contributor

Hi @alstn2468!

Thank you for your pull request and welcome to our community.We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2020
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@alstn2468 alstn2468 changed the title Translate getting-started, installation to Korean Translate official document to Korean May 17, 2020
@alstn2468 alstn2468 changed the title Translate official document to Korean [docs] Translate official document to Korean May 19, 2020
@alstn2468 alstn2468 changed the title [docs] Translate official document to Korean [docs/korean] Translate official document to Korean May 19, 2020
@davidmccabe
Copy link
Contributor

Thanks so much for providing this, this is awesome!

My question is, since we're still changing the APIs and our docs are still being edited a lot, do we want to ship a translation that may fall out of date? Are you going to keep it up to date?

@alstn2468
Copy link
Author

I plan to keep it up to date. Recent changes have been reflected.

@drarmstr drarmstr added the documentation Improvements or additions to documentation label May 20, 2020
@alstn2468
Copy link
Author

alstn2468 commented Apr 9, 2021

Todo

Docs to korean

  • Installation
  • useGetRecoilValueInfo

Docusaurus i18n

  • current.json
  • footer.json
  • navbar.json
  • code.json

docs/i18n/ko/code.json Outdated Show resolved Hide resolved
@alstn2468
Copy link
Author

번역 문서 전체적인 문체, 어투를 통일해주 실 분을 찾습니다!

현재 여러 사람이 나누어 번역을 진행한 결과 -다, -니다 등 여러 문체가 섞여있는 것이 확인되었습니다!
실제 배포전 관련 사항을 하나로 통일하고 남은 2개의 문서에 대한 번역을 도와주실 분을 찾습니다.

최종적으로 번역되지 않은 문서는 Installation, useGetRecoilValueInfo가 존재합니다.

@drarmstr
Copy link
Contributor

@Mark-Yoo / @alstn2468 - #377 has now landed and we're hopefully ready to merge the Korean translation. However, it appears the branch currently has merge conflicts, perhaps due to #377? I think once that is resolved we can merge and publish these.

@drarmstr drarmstr merged commit a673d50 into facebookexperimental:docs Apr 19, 2021
@drarmstr
Copy link
Contributor

@alstn2468, thanks for the rebase and I merged the PR. However, it seems broken. There's a missing }, in docusaurus.config.js, which isn't a big deal, but after fixing that there's still an error with a missing } somewhere when executing yarn build.

@alstn2468
Copy link
Author

alstn2468 commented Apr 19, 2021

@drarmstr I think this comment will help you!

PR [facebook/docusaurus/pull/4599]

@drarmstr
Copy link
Contributor

@alstn2468 - That didn't seem to help, still getting the error:
image

@alstn2468
Copy link
Author

alstn2468 commented Apr 19, 2021

@drarmstr I had built by modifying the ko.json data directly from the package in node_modules.

image

Path: docs/node_modules/@docusaurus/theme-classic/codeTranslations/ko.json

@drarmstr
Copy link
Contributor

Did the partial fix in #975. The manual edit seems to fix the build then. Seems suspicious, and anyone who deploys will have to remember to patch it, but at least we can deploy it now!

@Mark-Yoo
Copy link

@alstn2468 수고하셨습니다. 방금 한국어가 디플로이 된 걸 확인했네요. 위에서 말씀하신것처럼 어투 통일 및 몇몇 파일의 번역이 필요하겠네요. 틈틈히 저도 수정할 수 있도록 하겠습니다.
다음 같은 사례가 있어 이를 참조해서 수정할 수 있도록 하겠습니다.
다시 한 번 수고 많으셨습니다. :) 👍

https://github.com/javascript-tutorial/ko.javascript.info/wiki/번역-모범-사례

@hg-pyun
Copy link

hg-pyun commented Apr 19, 2021

고생하셨습니다.

@pumpkin-raccoon
Copy link

pumpkin-raccoon commented Apr 26, 2021

안녕하세요, 이 풀리퀘를 못보고 installation 번역 풀리퀘를 올렸는데 따로 합쳐서 올리시던 중이셨나요??
(어투는 최대한 기존 번역과 맞추려했었습니다)

@alstn2468
Copy link
Author

@pumpkin-raccoon 안녕하세요~! 이미 한번 병합되어서 이제 문서 수정은 따로따로 pr올리셔도 괜찮을 것 같습니다!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet