-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TS types for getNodes and useGetRecoilValueInfo #1116
Conversation
Hi @AssafKr! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you @AssafKr :)
Hey @bryan-hunter! 👋 |
Thanks! Looks like |
@drarmstr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: Fix up some TypeScript exports. Based on facebookexperimental#1116 and fix up tests. Also drive-by some changes so we work with both TypeScript 3.8 and 3.9 which had some minor changes in formatting and which lines errors show up on. Differential Revision: D29863364 fbshipit-source-id: e36d57bfaf75e414f13a2e820fb60d5bef87b382
Summary: Fix up some TypeScript exports. Based on #1116 and fix up tests. Also drive-by some changes so we work with both TypeScript 3.8 and 3.9 which had some minor changes in formatting and which lines errors show up on. Reviewed By: csantos42 Differential Revision: D29863364 fbshipit-source-id: 9a23338c2ba0e0b0da991c9d3d4443584d75c158
Landed with #1123 |
No description provided.