Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS types for getNodes and useGetRecoilValueInfo #1116

Closed
wants to merge 1 commit into from

Conversation

AssafKr
Copy link

@AssafKr AssafKr commented Jul 13, 2021

No description provided.

@facebook-github-bot
Copy link
Contributor

Hi @AssafKr!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 13, 2021
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link

@bryan-hunter bryan-hunter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you @AssafKr :)

@AssafKr
Copy link
Author

AssafKr commented Jul 18, 2021

Hey @bryan-hunter! 👋

@drarmstr
Copy link
Contributor

drarmstr commented Jul 22, 2021

Thanks! Looks like tests.ts will also have to be updated. There was a PR import issue, so I can take care of the tests as well when fixing that in #1123

@facebook-github-bot
Copy link
Contributor

@drarmstr has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@drarmstr drarmstr mentioned this pull request Jul 22, 2021
drarmstr added a commit to drarmstr/Recoil that referenced this pull request Jul 22, 2021
Summary: Fix up some TypeScript exports.  Based on facebookexperimental#1116 and fix up tests.  Also drive-by some changes so we work with both TypeScript 3.8 and 3.9 which had some minor changes in formatting and which lines errors show up on.

Differential Revision: D29863364

fbshipit-source-id: e36d57bfaf75e414f13a2e820fb60d5bef87b382
facebook-github-bot pushed a commit that referenced this pull request Jul 23, 2021
Summary: Fix up some TypeScript exports.  Based on #1116 and fix up tests.  Also drive-by some changes so we work with both TypeScript 3.8 and 3.9 which had some minor changes in formatting and which lines errors show up on.

Reviewed By: csantos42

Differential Revision: D29863364

fbshipit-source-id: 9a23338c2ba0e0b0da991c9d3d4443584d75c158
@drarmstr
Copy link
Contributor

Landed with #1123

@drarmstr drarmstr closed this Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. TypeScript / Flow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants