Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up some Typescript #1123

Closed

Conversation

drarmstr
Copy link
Contributor

@drarmstr drarmstr commented Jul 22, 2021

Summary: Fix up some TypeScript exports. Based on #1116 from @AssafKr and fix up tests. Also drive-by some changes so we work with both TypeScript 3.8 and 3.9 which had some minor changes in formatting and which lines errors show up on.

Differential Revision: D29863364

Summary: Fix up some TypeScript exports.  Based on facebookexperimental#1116 and fix up tests.  Also drive-by some changes so we work with both TypeScript 3.8 and 3.9 which had some minor changes in formatting and which lines errors show up on.

Differential Revision: D29863364

fbshipit-source-id: e36d57bfaf75e414f13a2e820fb60d5bef87b382
@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jul 22, 2021
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D29863364

@drarmstr
Copy link
Contributor Author

landed

@drarmstr drarmstr closed this Jul 23, 2021
@drarmstr drarmstr deleted the export-D29863364 branch September 21, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants