Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy compute getNodeInfo() results #1549

Closed
wants to merge 2 commits into from

Conversation

drarmstr
Copy link
Contributor

Summary: Lazily compute the various properties of the results of useGetRecoilValueInfo_UNSTABLE() or Snapshot#getNodeInfo_UNSTABLE().

Differential Revision: D33560351

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported labels Jan 13, 2022
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33560351

@drarmstr drarmstr self-assigned this Jan 13, 2022
drarmstr added a commit to drarmstr/Recoil that referenced this pull request Jan 13, 2022
Summary:
Pull Request resolved: facebookexperimental#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27

fbshipit-source-id: 3a89cabe941ebe70f5748f5feca4e9d4e1646980
drarmstr added a commit to drarmstr/Recoil that referenced this pull request Jan 13, 2022
Summary:
Pull Request resolved: facebookexperimental#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27

fbshipit-source-id: f6ee7ff03ccd865a32974aaf7dd698ddba94a396
drarmstr added a commit to drarmstr/Recoil that referenced this pull request Jan 13, 2022
Summary:
Pull Request resolved: facebookexperimental#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27

fbshipit-source-id: a8495cb82ae9ff56426318b81f07e56f276b2479
Summary:
Pull Request resolved: facebookexperimental#1548

Optimize lazy properties by only computing them once and then memoizing the value.  Also fix the proxy objects to report the proper set of keys for both the static and lazy dynamic properties.

Differential Revision: https://www.internalfb.com/diff/D33559815?entry_point=27

fbshipit-source-id: 41547522e03a98daedc638e9bbab3b97848eddeb
Summary:
Pull Request resolved: facebookexperimental#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Reviewed By: habond

Differential Revision: D33560351

fbshipit-source-id: b76aad1b646af832e25c2534c8c628a9aec885ca
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D33560351

drarmstr added a commit to drarmstr/Recoil that referenced this pull request Jan 27, 2022
Summary:
Pull Request resolved: facebookexperimental#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27

fbshipit-source-id: 071d25582d83f81c16390eab296301b7968dcb04
drarmstr added a commit to drarmstr/Recoil that referenced this pull request Jan 27, 2022
Summary:
Pull Request resolved: facebookexperimental#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27

fbshipit-source-id: 64c32d7492370e57b8d1e9dac6406bd1cec0f048
@drarmstr drarmstr deleted the export-D33560351 branch January 29, 2022 07:05
AlexGuz23 pushed a commit to AlexGuz23/Recoil that referenced this pull request Nov 3, 2022
Summary:
Pull Request resolved: facebookexperimental/Recoil#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Reviewed By: habond

Differential Revision: D33560351

fbshipit-source-id: 18c1e6abf5ed39f5b6dc5a46ebec8a75339d13c3
snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
Summary:
Pull Request resolved: facebookexperimental/Recoil#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Reviewed By: habond

Differential Revision: D33560351

fbshipit-source-id: 18c1e6abf5ed39f5b6dc5a46ebec8a75339d13c3
eagle2722 added a commit to eagle2722/Recoil that referenced this pull request Sep 21, 2024
Summary:
Pull Request resolved: facebookexperimental/Recoil#1549

Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`.

Reviewed By: habond

Differential Revision: D33560351

fbshipit-source-id: 18c1e6abf5ed39f5b6dc5a46ebec8a75339d13c3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants