-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy compute getNodeInfo() results #1549
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
labels
Jan 13, 2022
This pull request was exported from Phabricator. Differential Revision: D33560351 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 13, 2022
Summary: Pull Request resolved: facebookexperimental#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27 fbshipit-source-id: 3a89cabe941ebe70f5748f5feca4e9d4e1646980
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 13, 2022
Summary: Pull Request resolved: facebookexperimental#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27 fbshipit-source-id: f6ee7ff03ccd865a32974aaf7dd698ddba94a396
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 13, 2022
Summary: Pull Request resolved: facebookexperimental#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27 fbshipit-source-id: a8495cb82ae9ff56426318b81f07e56f276b2479
Summary: Pull Request resolved: facebookexperimental#1548 Optimize lazy properties by only computing them once and then memoizing the value. Also fix the proxy objects to report the proper set of keys for both the static and lazy dynamic properties. Differential Revision: https://www.internalfb.com/diff/D33559815?entry_point=27 fbshipit-source-id: 41547522e03a98daedc638e9bbab3b97848eddeb
Summary: Pull Request resolved: facebookexperimental#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Reviewed By: habond Differential Revision: D33560351 fbshipit-source-id: b76aad1b646af832e25c2534c8c628a9aec885ca
drarmstr
force-pushed
the
export-D33560351
branch
from
January 27, 2022 21:06
59c3d50
to
63dbefa
Compare
This pull request was exported from Phabricator. Differential Revision: D33560351 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 27, 2022
Summary: Pull Request resolved: facebookexperimental#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27 fbshipit-source-id: 071d25582d83f81c16390eab296301b7968dcb04
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Jan 27, 2022
Summary: Pull Request resolved: facebookexperimental#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Differential Revision: https://www.internalfb.com/diff/D33560351?entry_point=27 fbshipit-source-id: 64c32d7492370e57b8d1e9dac6406bd1cec0f048
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Reviewed By: habond Differential Revision: D33560351 fbshipit-source-id: 18c1e6abf5ed39f5b6dc5a46ebec8a75339d13c3
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Reviewed By: habond Differential Revision: D33560351 fbshipit-source-id: 18c1e6abf5ed39f5b6dc5a46ebec8a75339d13c3
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1549 Lazily compute the various properties of the results of `useGetRecoilValueInfo_UNSTABLE()` or `Snapshot#getInfo_UNSTABLE()`. Reviewed By: habond Differential Revision: D33560351 fbshipit-source-id: 18c1e6abf5ed39f5b6dc5a46ebec8a75339d13c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
performance
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Lazily compute the various properties of the results of
useGetRecoilValueInfo_UNSTABLE()
orSnapshot#getNodeInfo_UNSTABLE()
.Differential Revision: D33560351