Rename reshape to avoid acc tracer collision #838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: There is an AIT bug See this acc_graph: P795462043, and model-generated.h: P795461857 When the node name is the same as function name - in this case, reshape_14 we will have ``` expression preceding parentheses of apparent call must have (pointer-to-) function type ``` This is because reshape_14 is both tensor and function (see model-generated.h: P795461857) The fix can be either add func name to MEMO set (D47657410), or name our reshape function so that it would cause any name collision to the name produced by the acc tracer (this diff). We probably chose the latter because the former may might end up with a very large name set and long compilation time. The later approach isn't general but I guess we don’t have many cases where we name our kernel launchers the same way as what the acc tracer names tensors. Differential Revision: D47675840 fbshipit-source-id: 21395181fb7610cc5feaccf953dbee0dfc900f51
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D47675840 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
There is an AIT bug
See this acc_graph: P795462043, and model-generated.h: P795461857
When the node name is the same as function name - in this case, reshape_14
we will have
This is because reshape_14 is both tensor and function (see model-generated.h: P795461857)
The fix can be either add func name to MEMO set (D47657410), or name our reshape function so that it would cause any name collision to the name produced by the acc tracer (this diff).
We probably chose the latter because the former may might end up with a very large name set and long compilation time.
The later approach isn't general but I guess we don’t have many cases where we name our kernel launchers the same way as what the acc tracer names tensors.
Differential Revision: D47675840