Allow concurrent indexing in glean index cpp-cmake #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be landed together with facebookincubator/hsthrift#102 which removes ffi.h from fb-util
This is necessary to support parallel indexing in the `cpp-cmake` CLI. It's a bit of a hack but seems to be the best way of doing this at the moment since we want to be able to obtain this from LLVM CDBs.
This uses the existing worklist support. There are some shenanigans related to progress reporting which mostly exist to make indexing LLVM nicer (script coming up). Tested with -j16 for indexing LLVM.
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for fb-oss-glean canceled.
|
This runs the indexer on the LLVM source distribution. I think it's a good demo. `index-llvm.sh --help` gives a complete example. I'm not sure where the script should live, though.
rleshchinskiy
force-pushed
the
rl-cpp-index-dev
branch
from
d581d8b
to
51dc6f4
Compare
|
@donsbot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This removes all remaining missing header file errors.
alpmestan
approved these changes
Sep 12, 2022
index-llvm.sh
Outdated
| dir=$(dirname "${dir}") | ||
| done | ||
| if [[ -z "${GLEAN_DIR}" ]] ; then | ||
| fatal "Couldn't local Glean source directory, please specify --glean" |
|
@donsbot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@donsbot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pepeiborra has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
pepeiborra
requested changes
Sep 25, 2022
pepeiborra
approved these changes
Sep 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for concurrent indexing based on the existing worklist framework. There are some shenanigans
related to progress reporting which mostly exist to make indexing LLVM nicer (script coming up).
The other major addition is the index-llvm.sh script which automates indexing LLVM source distributions using the parallel indexer - try the example suggested in index-llvm.sh --help. I'm not sure where the script should live. On my server indexing takes about 10 min with -j16.
Note that this includes #269 - we don't have stacked PRs so that one should probably be landed first.