Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying and Pasting do not seem to work #638

Closed
Bonkles opened this issue Oct 31, 2022 · 1 comment
Closed

Copying and Pasting do not seem to work #638

Bonkles opened this issue Oct 31, 2022 · 1 comment
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Bonkles
Copy link
Contributor

Bonkles commented Oct 31, 2022

Tried copying and pasting various entities- sometimes I would get the 'copied a feature' toast, but pasting never worked.

Right-clicking anywhere on the map does not seem to bring up the context menu either.

@Bonkles Bonkles added this to the v2 Alpha 3 milestone Oct 31, 2022
@Bonkles Bonkles self-assigned this Nov 8, 2022
@Bonkles
Copy link
Contributor Author

Bonkles commented Nov 8, 2022

Fixed in e8839fde2.

Okay, there were a couple of issues here:

context.copyLatLon had been renamed to context.copyLoc during last month's refactoring. Fixed that.

the ModeBrowse module was loading the paste operation in its constructor, which was too early before the localizer had been called. Therefore, the paste operation's title / etc. was messed up, and had a genertic 'no translationfor language en'. I fixed this by moving the operation into the 'enter' method, which doesn't get called until the operation is needed.

@Bonkles Bonkles closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant