Skip to content

Commit

Permalink
Fix a flaky test
Browse files Browse the repository at this point in the history
Summary: This test is flakey as it turns a hashmap into a vector, where order is nondeterministic.. Sort before comparing.

Differential Revision: D54701378

fbshipit-source-id: d5df66aa148eff10fd6d0120ba6a68feda6deed9
  • Loading branch information
Xiang Gao authored and facebook-github-bot committed Mar 9, 2024
1 parent 1dc17d8 commit b00a0d8
Showing 1 changed file with 18 additions and 11 deletions.
29 changes: 18 additions & 11 deletions td_util/src/xplat.rs
Original file line number Diff line number Diff line change
Expand Up @@ -64,20 +64,27 @@ mod tests {
),
];

let sorted = |mut v: Vec<(String, String)>| -> Vec<(String, String)> {
v.sort();
v
};

assert_eq!(
unpack_project_metadata(TdProject::Fbandroid, &job_metadata),
[
vec![
("test.abc".into(), "1".into()),
("test.def".into(), "2".into())
],
job_metadata.clone(),
]
.concat()
sorted(unpack_project_metadata(TdProject::Fbandroid, &job_metadata)),
sorted(
[
vec![
("test.abc".into(), "1".into()),
("test.def".into(), "2".into())
],
job_metadata.clone(),
]
.concat()
)
);
assert_eq!(
unpack_project_metadata(TdProject::Fbobjc, &job_metadata),
[vec![("test.xyz".into(), "1".into()),], job_metadata.clone(),].concat()
sorted(unpack_project_metadata(TdProject::Fbobjc, &job_metadata)),
sorted([vec![("test.xyz".into(), "1".into()),], job_metadata.clone(),].concat())
);
}
}

0 comments on commit b00a0d8

Please sign in to comment.