Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to good basic example apps #1381

Closed
gaearon opened this issue Jan 12, 2017 · 6 comments
Closed

Link to good basic example apps #1381

gaearon opened this issue Jan 12, 2017 · 6 comments
Labels
tag: documentation

Comments

@gaearon
Copy link
Contributor

gaearon commented Jan 12, 2017

I think we should have a page with example apps like these two built by @ahfarmer.
Then we could link from the default App template to that page so people can discover them.

Thoughts?
@gaearon gaearon added the docs label Jan 12, 2017
@krsjoseph
Copy link

@gaearon I'll take this on.

@gaearon
Copy link
Contributor Author

gaearon commented Jan 24, 2017

Sounds great!

@krsjoseph
Copy link

krsjoseph commented Jan 24, 2017 •
edited
Loading

Where should this page be hosted?

We can go really simple and just create a EXAMPLES.md file in the repo and link to that from the App.js component and a link in the cli after you run create-react-app

Or it be a page hosted and on a simple wiki or a like React

Or it be a could be a new Example component in the template files
image

I'm good with doing any of these. Let me know what you think @gaearon

krsjoseph added a commit to krsjoseph/create-react-app that referenced this issue Jan 24, 2017
@krsjoseph
Add links to good basic example apps. (facebook#1381)
4ae00d0 
* Add EXAMPLES.md file
* Update README.md to link to examples doc
* Add link in App.js template file to examples doc
@krsjoseph krsjoseph mentioned this issue Jan 24, 2017
Closed
@krsjoseph
Copy link

bump

@gaearon
Copy link
Contributor Author

gaearon commented Feb 24, 2017

Reviewed, thanks!

@gaearon
Copy link
Contributor Author

gaearon commented Jan 8, 2018

Closing as stale.

@gaearon gaearon closed this as completed Jan 8, 2018
@lock lock bot locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
tag: documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gaearon @krsjoseph