Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uncore events for modern (ICL+) Intel Architectures #253

Closed

Conversation

williamsumendap
Copy link
Contributor

Summary: Add uncore events to hbt library.

Differential Revision: D56407110

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 22, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request Apr 22, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 11, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 15, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 15, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 17, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 20, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 22, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 22, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 22, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 22, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 24, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 24, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: D56407110
williamsumendap and others added 2 commits May 28, 2024 18:05
…tor#254)

Summary:
Pull Request resolved: facebookincubator#254

Some events have the same code and umask, thus having identical configuration under hbt's event definitions.

This should not be the case, however, because Intel differentiates them via umask extensions that wasn't parsed prior to this diff.

NOTE: `fbcode/hbt/src/perf_event/json_events/fb/generate.py` are manual changes (by me), but the file is marked generated by D55156319

Differential Revision: https://internalfb.com/D56416468
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Reviewed By: Alston-Tang

Differential Revision: D56407110
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D56407110

williamsumendap added a commit to williamsumendap/dynolog-1 that referenced this pull request May 30, 2024
…bator#253)

Summary:
Pull Request resolved: facebookincubator#253

Add uncore events to hbt library.

Differential Revision: https://internalfb.com/D56407110
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in bf16b13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants