Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: Removes the outdated HIP flags appended to HIP_CXX_FLAGS The will help remove the following warnings in the pytorch build log ``` [6238/6889] Building CXX object caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/cudnn/hip/Conv_v8.cpp.o cc1plus: warning: command line option ‘-Wno-duplicate-decl-specifier’ is valid for C/ObjC but not for C++ cc1plus: warning: unrecognized command line option ‘-Wno-unused-command-line-argument’ cc1plus: warning: unrecognized command line option ‘-Wno-exceptions’ cc1plus: warning: unrecognized command line option ‘-Wno-inconsistent-missing-override’ cc1plus: warning: unrecognized command line option ‘-Wno-macro-redefined’ ``` (There is a similar change also required in `pytorch/cmake/Dependencies.cmake` to fully remove these warnings) This PR also replaces the deprecated `--amdgpu-target` hip flag with `--offload-arch` as previously updated in pytorch https://github.com/pytorch/pytorch/pull/97620/files cc: pruthvistony Pull Request resolved: #360 Reviewed By: zou3519 Differential Revision: D46023158 Pulled By: malfet fbshipit-source-id: 1444a6ccae27f008a8ca7f5dd95df026c15b48dc
- Loading branch information