Remove deprecated HIP flags #360
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the outdated HIP flags appended to HIP_CXX_FLAGS The will help remove the following warnings in the pytorch build log ``` [6238/6889] Building CXX object caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/cudnn/hip/Conv_v8.cpp.o cc1plus: warning: command line option ‘-Wno-duplicate-decl-specifier’ is valid for C/ObjC but not for C++ cc1plus: warning: unrecognized command line option ‘-Wno-unused-command-line-argument’ cc1plus: warning: unrecognized command line option ‘-Wno-exceptions’ cc1plus: warning: unrecognized command line option ‘-Wno-inconsistent-missing-override’ cc1plus: warning: unrecognized command line option ‘-Wno-macro-redefined’ ``` There is a similar change also required in `pytorch/cmake/Dependencies.cmake` to fully remove these warnings
|
Hey @malfet are you able to take a look at this or point me in the right direction to get this approved. Thank you! cc: @pruthvistony |
malfet
approved these changes
May 19, 2023
|
@malfet has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
lisaong
pushed a commit
to lisaong/gloo
that referenced
this pull request
Feb 19, 2024
Summary: Removes the outdated HIP flags appended to HIP_CXX_FLAGS The will help remove the following warnings in the pytorch build log ``` [6238/6889] Building CXX object caffe2/CMakeFiles/torch_hip.dir/__/aten/src/ATen/native/cudnn/hip/Conv_v8.cpp.o cc1plus: warning: command line option ‘-Wno-duplicate-decl-specifier’ is valid for C/ObjC but not for C++ cc1plus: warning: unrecognized command line option ‘-Wno-unused-command-line-argument’ cc1plus: warning: unrecognized command line option ‘-Wno-exceptions’ cc1plus: warning: unrecognized command line option ‘-Wno-inconsistent-missing-override’ cc1plus: warning: unrecognized command line option ‘-Wno-macro-redefined’ ``` (There is a similar change also required in `pytorch/cmake/Dependencies.cmake` to fully remove these warnings) This PR also replaces the deprecated `--amdgpu-target` hip flag with `--offload-arch` as previously updated in pytorch https://github.com/pytorch/pytorch/pull/97620/files cc: pruthvistony Pull Request resolved: facebookincubator#360 Reviewed By: zou3519 Differential Revision: D46023158 Pulled By: malfet fbshipit-source-id: 1444a6ccae27f008a8ca7f5dd95df026c15b48dc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the outdated HIP flags appended to HIP_CXX_FLAGS
The will help remove the following warnings in the pytorch build log
(There is a similar change also required in
pytorch/cmake/Dependencies.cmaketo fully remove these warnings)This PR also replaces the deprecated
--amdgpu-targethip flag with--offload-archas previously updated in pytorch https://github.com/pytorch/pytorch/pull/97620/filescc: @pruthvistony