Skip to content

Commit

Permalink
Drop dependency on mysql in the OSS build (#87)
Browse files Browse the repository at this point in the history
Summary:
This dep only exists for an instance of MySQL.Param, which is used no where in the OSS code.
Drop the dep entirely.

There's a separate fix to mysql-simple over on paul-rouse/mysql-simple#56 , but we don't need to wait for it.

Pull Request resolved: #87

Reviewed By: simonmar

Differential Revision: D36756634

Pulled By: pepeiborra

fbshipit-source-id: 719fb04f64657f7f6cbbc3f68cc765e76c0d63b3
  • Loading branch information
donsbot authored and facebook-github-bot committed Jun 1, 2022
1 parent 3874498 commit df99a39
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 8 deletions.
4 changes: 1 addition & 3 deletions README.md
Expand Up @@ -118,7 +118,6 @@ not have IPv6 configured.
sudo apt install \
libgoogle-glog-dev \
libgflags-dev \
libmysqlclient-dev \
bison \
flex \
ninja-build \
Expand Down Expand Up @@ -149,8 +148,7 @@ sudo yum install \
pcre-devel \
ncurses-devel \
fmt-devel \
gmp-devel \
community-mysql-devel
gmp-devel
```

Also you may need:
Expand Down
4 changes: 0 additions & 4 deletions common/util/Util/TimeSec.hs
Expand Up @@ -18,7 +18,6 @@ module Util.TimeSec
, PPTimeSpanGranularity(..)
) where

import Database.MySQL.Simple.Param
import Data.Aeson
import Data.Text (Text)
import qualified Data.Text as Text
Expand All @@ -39,9 +38,6 @@ newtype Time = Time { timeInSeconds :: Int }
instance NFData Time
instance Hashable Time

instance Param Time where
render = render . timeInSeconds

-- | 'TimeSpan' means a time difference, duration in seconds,
-- as opposed to 'Time', which is a specific point in time
-- (a unix timestamp).
Expand Down
1 change: 0 additions & 1 deletion common/util/fb-util.cabal
Expand Up @@ -191,7 +191,6 @@ library
aeson-pretty,
either,
QuickCheck,
mysql-simple,
scientific,
haskell-src-exts,
stm,
Expand Down

0 comments on commit df99a39

Please sign in to comment.