Fix build on ghc 8.4.x #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The English spelling isn't accepted until ghc 8.6 series. Caught by glean cI: https://github.com/facebookincubator/Glean/runs/6646154634?check_suite_focus=true#step:18:704
|
The recent commit facfb42 introduced an accidental non-backwards compatible extension name, which causes build failures on 8.4.x series. This PR fixes it. Please merge, as this breaks the Glean CI. |
|
Fair enough - thanks. I'll merge and release. I guess I should be more aggressive about the lower bound on |
facebook-github-bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Jun 1, 2022
Summary: This dep only exists for an instance of MySQL.Param, which is used no where in the OSS code. Drop the dep entirely. There's a separate fix to mysql-simple over on paul-rouse/mysql-simple#56 , but we don't need to wait for it. Pull Request resolved: #87 Reviewed By: simonmar Differential Revision: D36756634 Pulled By: pepeiborra fbshipit-source-id: 719fb04f64657f7f6cbbc3f68cc765e76c0d63b3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The English spelling isn't accepted until ghc 8.6 series.
Caught by glean cI:
https://github.com/facebookincubator/Glean/runs/6646154634?check_suite_focus=true#step:18:704