Fix quoting of paths in various places #1602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
jrapin
approved these changes
Jan 27, 2021
submitit/slurm/test_slurm.py
Outdated
Comment on lines
349
to
350
| if "\n" in weird_dir: | ||
| pytest.skip("test doesn't support newline in 'weird_dir'") |
There was a problem hiding this comment.
is it supported by slurm? if not then raise there maybe?
There was a problem hiding this comment.
I believe that newline in filename is supported by sbatch but not by my crappy sbatch parsing test code. Can I change the message to make this more clear ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially for #1600, but the LocalExecutor also had some minor bugs.
I added some more shlex.quote in the code.
New failing tests:
https://app.circleci.com/pipelines/github/facebookincubator/submitit/151/workflows/46d4118f-9262-49b4-936b-08b5ce9d830a/jobs/715/tests
Fix tests:
https://app.circleci.com/pipelines/github/facebookincubator/submitit/152/workflows/25407c90-c3bd-421f-9144-4b1810269d6f/jobs/723/tests