Add Filter::mergeWith() method #119
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbasmanova
requested review from
kgpai,
spershin,
pedroerp,
oerling and
amitkdutta
facebook-github-bot
added
the
CLA Signed
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
kgpai
reviewed
Aug 26, 2021
velox/type/Filter.cpp
Outdated
| case FilterKind::kAlwaysFalse: | ||
| case FilterKind::kIsNull: | ||
| return std::make_unique<AlwaysFalse>(); | ||
| case FilterKind::kIsNotNull: |
There was a problem hiding this comment.
nit: maybe this can be moved up to be next to kAlwaysTrue, so the fall through in both is same.
mbasmanova
force-pushed
the
merge-filters
branch
2 times, most recently
from
28d5a95
to
b00b71f
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
mbasmanova
force-pushed
the
merge-filters
branch
2 times, most recently
from
999e61a
to
ff93f0c
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Add a way to combine two filters using 'AND' logic. This commit implements the new method for all filters except BytesRange, BigintMultiRange and MultiRange. The support for these filters will come in a follow-up PR.
mbasmanova
force-pushed
the
merge-filters
branch
from
ff93f0c
to
6baf3a6
Compare
|
@mbasmanova has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 95911db. |
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 1, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - Handling case of merging multiple byte ranges which results in MultiRange as the output - Merging MultiRange with MultiRange
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 1, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - Handling case of merging multiple byte ranges which results in MultiRange as the output - Merging MultiRange with MultiRange
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 2, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - Handling case of merging multiple byte ranges which results in MultiRange as the output - Merging MultiRange with MultiRange
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 5, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - (New PR) Handling case of merging multiple byte ranges which results in MultiRange as the output
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 5, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - (New PR) Handling case of merging multiple byte ranges which results in MultiRange as the output
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 5, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - (New PR) Handling case of merging multiple byte ranges which results in MultiRange as the output
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 5, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - (New PR) Handling case of merging multiple byte ranges which results in MultiRange as the output
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 5, 2021
This commit is a follow up of facebookincubator#119 and introduces mergeWith implmentation for BytesRange and BytesValues. TODO: - (New PR) Handling case of merging multiple byte ranges which results in MultiRange as the output
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 6, 2021
This commit is a follow up of facebookincubator#119. TODO: - (New PR) Handling case of merging multiple byte ranges which results in MultiRange as the output
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 6, 2021
This commit is a follow up of facebookincubator#119. TODO: - (New PR) Handling case of merging multiple byte ranges which results in MultiRange as the output
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 6, 2021
This commit is a follow up of facebookincubator#119.
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 6, 2021
This commit is a follow up of facebookincubator#119.
atanu1991
added a commit
to atanu1991/velox-1
that referenced
this pull request
Oct 7, 2021
) Summary: Implement BytesRange::mergeWith and BytesValues::mergeWith This commit is a follow up of facebookincubator#119. Pull Request resolved: facebookincubator#297 Reviewed By: mbasmanova Differential Revision: D31444325 Pulled By: atanu1991 fbshipit-source-id: 3e8d8bb2645455fcaf24ebd18d6c122613221958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a way to combine two filters using 'AND' logic.
This commit implements the new method for all filters except BytesRange
and MultiRange. The support for these filters will come in a follow-up PR.