Fix timezone issue in date_diff #8540
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53105892 |
Summary: In Presto Jave, timestamp with time zone in date_diff is converted to timestamp as GMT (simply drop the timezone field). Velox needs to match this behavior. Presto code ref: https://github.com/prestodb/presto/blob/0.286-edge17/presto-main/src/main/java/com/facebook/presto/operator/scalar/DateTimeFunctions.java#L500 Reviewed By: Yuhta Differential Revision: D53105892
zacw7
force-pushed
the
export-D53105892
branch
from
024bda1
to
c2ecda3
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53105892 |
|
This pull request has been merged in 0698b7e. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
In Presto Jave, timestamp with time zone is converted to timestamp as
GMT (simply drop the timezone field). Velox needs to match this
behavior.
Differential Revision: D53105892