Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timezone issue in date_diff #8540

Closed
wants to merge 1 commit into from
Closed

Fix timezone issue in date_diff #8540

wants to merge 1 commit into from

Commits on Jan 29, 2024

  1. Fix timezone issue in date_diff 

    Summary:
In Presto Jave, timestamp with time zone in date_diff is converted to
timestamp as GMT (simply drop the timezone field). Velox needs to match
this behavior.
Presto code ref: https://github.com/prestodb/presto/blob/0.286-edge17/presto-main/src/main/java/com/facebook/presto/operator/scalar/DateTimeFunctions.java#L500

Reviewed By: Yuhta

Differential Revision: D53105892
    @zacw7 @facebook-github-bot
    zacw7 authored and facebook-github-bot committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    c2ecda3 View commit details
    Browse the repository at this point in the history