Fix JsonExprBenchmark.cpp #9574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56452087 |
✅ Deploy Preview for meta-velox canceled.
|
Summary: - Replace folly::StringPiece with std::string_view. - Replace `folly::Expected<std::string, bool>` with `std::optional<std::string>`. - Replace private methods isDotKeyFormat and isUnquotedBracketKeyFormat with free functions in .cpp file. Differential Revision: D56451797
Summary: Benchmark used to fail because it didn't initialize memory manager. Differential Revision: D56452087
mbasmanova
force-pushed
the
export-D56452087
branch
from
e13362d
to
0d844c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D56452087 |
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 23, 2024
Summary: Benchmark used to fail because it didn't initialize memory manager. Differential Revision: D56452087
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 23, 2024
Summary: Benchmark used to fail because it didn't initialize memory manager. Reviewed By: xiaoxmeng Differential Revision: D56452087
mbasmanova
added a commit
to mbasmanova/velox-1
that referenced
this pull request
Apr 23, 2024
Summary: Benchmark used to fail because it didn't initialize memory manager. Reviewed By: xiaoxmeng Differential Revision: D56452087
|
This pull request has been merged in fb9355d. |
|
Conbench analyzed the 1 benchmark run on commit There was 1 benchmark result indicating a performance regression:
The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9574 Benchmark used to fail because it didn't initialize memory manager. Reviewed By: xiaoxmeng Differential Revision: D56452087 fbshipit-source-id: b564b457728b0efff49e2b72c3aed5aa99dedd1d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Benchmark used to fail because it didn't initialize memory manager.
Differential Revision: D56452087