Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JsonExprBenchmark.cpp #9574

Closed
wants to merge 2 commits into from
Closed

Fix JsonExprBenchmark.cpp #9574

wants to merge 2 commits into from

Commits on Apr 23, 2024

  1. Refactor JsonPathTokenizer (facebookincubator#9573) 

    Summary:

- Replace folly::StringPiece with std::string_view.
- Replace `folly::Expected<std::string, bool>` with `std::optional<std::string>`.
- Replace private methods isDotKeyFormat and isUnquotedBracketKeyFormat with free functions in .cpp file.

Differential Revision: D56451797
    @mbasmanova @facebook-github-bot
    mbasmanova authored and facebook-github-bot committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6552e55 View commit details
    Browse the repository at this point in the history

  2. Fix JsonExprBenchmark.cpp (facebookincubator#9574) 

    Summary:

Benchmark used to fail because it didn't initialize memory manager.

Differential Revision: D56452087
    @mbasmanova @facebook-github-bot
    mbasmanova authored and facebook-github-bot committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    0d844c9 View commit details
    Browse the repository at this point in the history