Fix NaN handling in map_subset #9893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
facebook-github-bot
added
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 22, 2024
Summary: Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Differential Revision: D57681657
bikramSingh91
force-pushed
the
export-D57681657
branch
from
3863707
to
31f77c9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 22, 2024
Summary: Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Differential Revision: D57681657
bikramSingh91
force-pushed
the
export-D57681657
branch
from
31f77c9
to
4d2b732
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 22, 2024
Summary: Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Differential Revision: D57681657
bikramSingh91
force-pushed
the
export-D57681657
branch
from
4d2b732
to
916dffa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 22, 2024
Summary: Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Differential Revision: D57681657
bikramSingh91
force-pushed
the
export-D57681657
branch
from
916dffa
to
a4dbe5e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
May 22, 2024
Summary: Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Differential Revision: D57681657
bikramSingh91
force-pushed
the
export-D57681657
branch
from
a4dbe5e
to
99d4c01
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
bikramSingh91
force-pushed
the
export-D57681657
branch
from
99d4c01
to
3c65353
Compare
bikramSingh91
pushed a commit
to bikramSingh91/velox
that referenced
this pull request
Jun 1, 2024
Summary: Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Summary of changes: - For primitive type keys: Use a map that employs the correct hashing and equality operators for floating types. - For complex type keys: It uses GenericView as a key that uses BaseVector's hashing and equality operators. Those recursively call SimpleVector's respective functions that were addressed in facebookincubator#9963 Differential Revision: D57681657
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
Summary: Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Summary of changes: - For primitive type keys: Use a map that employs the correct hashing and equality operators for floating types. - For complex type keys: It uses GenericView as a key that uses BaseVector's hashing and equality operators. Those recursively call SimpleVector's respective functions that were addressed in facebookincubator#9963 Differential Revision: D57681657
bikramSingh91
force-pushed
the
export-D57681657
branch
from
3c65353
to
2d27791
Compare
|
This pull request was exported from Phabricator. Differential Revision: D57681657 |
|
This pull request has been merged in a10bd49. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9893 Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Summary of changes: - For primitive type keys: Use a map that employs the correct hashing and equality operators for floating types. - For complex type keys: It uses GenericView as a key that uses BaseVector's hashing and equality operators. Those recursively call SimpleVector's respective functions that were addressed in facebookincubator#9963 Reviewed By: spershin Differential Revision: D57681657 fbshipit-source-id: 0ce281f303dd0633e698e4b386627c3831567d92
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
Summary: Pull Request resolved: facebookincubator#9893 Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Summary of changes: - For primitive type keys: Use a map that employs the correct hashing and equality operators for floating types. - For complex type keys: It uses GenericView as a key that uses BaseVector's hashing and equality operators. Those recursively call SimpleVector's respective functions that were addressed in facebookincubator#9963 Reviewed By: spershin Differential Revision: D57681657 fbshipit-source-id: 0ce281f303dd0633e698e4b386627c3831567d92
deepashreeraghu
pushed a commit
to deepashreeraghu/velox
that referenced
this pull request
Jun 13, 2024
Summary: Pull Request resolved: facebookincubator#9893 Ensure NaNs values of any binary representations are treated as equal and can be identified as keys in a map. Summary of changes: - For primitive type keys: Use a map that employs the correct hashing and equality operators for floating types. - For complex type keys: It uses GenericView as a key that uses BaseVector's hashing and equality operators. Those recursively call SimpleVector's respective functions that were addressed in facebookincubator#9963 Reviewed By: spershin Differential Revision: D57681657 fbshipit-source-id: 0ce281f303dd0633e698e4b386627c3831567d92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Ensure NaNs values of any binary representations are treated as equal and
can be identified as keys in a map.
Depends on #9893 #9963
Differential Revision: D57681657