Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NaN handling in map_subset #9893

Closed
wants to merge 1 commit into from
Closed

Fix NaN handling in map_subset #9893

wants to merge 1 commit into from

Commits on Jun 1, 2024

  1. Fix NaN handling in map_subset (facebookincubator#9893) 

    Summary:

Ensure NaNs values of any binary representations are treated as equal and
can be identified as keys in a map.

Summary of changes:
- For primitive type keys: Use a map that employs the correct hashing and
equality operators for floating types.
- For complex type keys: It uses GenericView as a key that uses BaseVector's
hashing and equality operators. Those recursively call SimpleVector's
respective functions that were addressed in facebookincubator#9963

Differential Revision: D57681657
    @facebook-github-bot
    Bikramjeet Vig authored and facebook-github-bot committed Jun 1, 2024
    Configuration menu
    Copy the full SHA
    2d27791 View commit details
    Browse the repository at this point in the history