Refactor AggregateCompanionAdapter to remove duplicate code #9920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
wypb
force-pushed
the
refactor_AggregateCompanionAdapter
branch
from
7e4ee37
to
db35de2
Compare
kagamiori
approved these changes
Jun 3, 2024
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
kagamiori
reviewed
Jun 3, 2024
| registered |= exec::registerStatefulVectorFunction( | ||
| CompanionSignatures::extractFunctionNameWithSuffix(originalName, type), | ||
| extractSignatures, | ||
| factory, |
There was a problem hiding this comment.
nit: std::move(extractSignatures) and std::move(factory). Ditto for lines 503--504.
There was a problem hiding this comment.
Hi @kagamiori Thank you for your reply. I've reconstructed it and synchronized the latest code.
wypb
force-pushed
the
refactor_AggregateCompanionAdapter
branch
2 times, most recently
from
977ff97
to
fe8c99c
Compare
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
wypb
force-pushed
the
refactor_AggregateCompanionAdapter
branch
from
fe8c99c
to
608beaf
Compare
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@kagamiori merged this pull request in 3aebeb6. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…incubator#9920) Summary: Refactor AggregateCompanionAdapter to remove duplicate code. CC: kagamiori mbasmanova Pull Request resolved: facebookincubator#9920 Reviewed By: pedroerp Differential Revision: D58087248 Pulled By: kagamiori fbshipit-source-id: e9b726eed5cf39b45470c8938143d5a112149789
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…incubator#9920) Summary: Refactor AggregateCompanionAdapter to remove duplicate code. CC: kagamiori mbasmanova Pull Request resolved: facebookincubator#9920 Reviewed By: pedroerp Differential Revision: D58087248 Pulled By: kagamiori fbshipit-source-id: e9b726eed5cf39b45470c8938143d5a112149789
deepashreeraghu
pushed a commit
to deepashreeraghu/velox
that referenced
this pull request
Jun 13, 2024
…incubator#9920) Summary: Refactor AggregateCompanionAdapter to remove duplicate code. CC: kagamiori mbasmanova Pull Request resolved: facebookincubator#9920 Reviewed By: pedroerp Differential Revision: D58087248 Pulled By: kagamiori fbshipit-source-id: e9b726eed5cf39b45470c8938143d5a112149789
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor AggregateCompanionAdapter to remove duplicate code.
CC: @kagamiori @mbasmanova