-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor AggregateCompanionAdapter to remove duplicate code #9920
Refactor AggregateCompanionAdapter to remove duplicate code #9920
Conversation
✅ Deploy Preview for meta-velox canceled.
|
7e4ee37
to
db35de2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you for the refactoring!
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @wypb, could you please rebase this PR onto the latest main? Thanks!
registered |= exec::registerStatefulVectorFunction( | ||
CompanionSignatures::extractFunctionNameWithSuffix(originalName, type), | ||
extractSignatures, | ||
factory, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: std::move(extractSignatures) and std::move(factory). Ditto for lines 503--504.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @kagamiori Thank you for your reply. I've reconstructed it and synchronized the latest code.
977ff97
to
fe8c99c
Compare
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
fe8c99c
to
608beaf
Compare
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
@kagamiori merged this pull request in 3aebeb6. |
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
…incubator#9920) Summary: Refactor AggregateCompanionAdapter to remove duplicate code. CC: kagamiori mbasmanova Pull Request resolved: facebookincubator#9920 Reviewed By: pedroerp Differential Revision: D58087248 Pulled By: kagamiori fbshipit-source-id: e9b726eed5cf39b45470c8938143d5a112149789
…incubator#9920) Summary: Refactor AggregateCompanionAdapter to remove duplicate code. CC: kagamiori mbasmanova Pull Request resolved: facebookincubator#9920 Reviewed By: pedroerp Differential Revision: D58087248 Pulled By: kagamiori fbshipit-source-id: e9b726eed5cf39b45470c8938143d5a112149789
…incubator#9920) Summary: Refactor AggregateCompanionAdapter to remove duplicate code. CC: kagamiori mbasmanova Pull Request resolved: facebookincubator#9920 Reviewed By: pedroerp Differential Revision: D58087248 Pulled By: kagamiori fbshipit-source-id: e9b726eed5cf39b45470c8938143d5a112149789
Refactor AggregateCompanionAdapter to remove duplicate code.
CC: @kagamiori @mbasmanova