Add a mechanism for sending arbitrary data payloads to the backend #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a mechanism to the CompilerGym client/service architecture so that the client can send arbitrary data messages to the service, which can then generate a response. This can be used by particular client/service implementations to provide a "back door" for talking to the service in a way that doesn't conform to the normal RL environment communication pattern. github.com/facebookresearch/issues/312
facebook-github-bot
added
the
CLA Signed
Codecov Report
@@ Coverage Diff @@
## development #313 +/- ##
===============================================
+ Coverage 85.61% 85.63% +0.01%
===============================================
Files 87 87
Lines 4687 4700 +13
===============================================
+ Hits 4013 4025 +12
- Misses 674 675 +1
Continue to review full report at Codecov.
|
Fix an invalid variable name error and the return type annotation.
Don't make send_params() return type change based on the nunmber of calling arguments. Instead, add an explicit singular version of the method. Issue facebookresearch#312.
|
Updated based on @hughleat's feedback:
Cheers, |
This was referenced Sep 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a mechanism to the CompilerGym client/service
architecture so that the client can send arbitrary data messages to
the service, which can then generate a response. This can be used by
particular client/service implementations to provide a "back door" for
talking to the service in a way that doesn't conform to the normal RL
environment communication pattern.
Fixes #312.