Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make derived observation spaces compatible with constructor. #463

Merged
merged 3 commits into from
Oct 12, 2021

Conversation

ChrisCummins
Copy link
Contributor

@ChrisCummins ChrisCummins commented Oct 11, 2021

This deprecates env.observation.add_derived_space() in favor of a derived_observation_spaces argument to the CompilerEnv constructor. This enabled derived spaces to be used in gym.make(...) invocations.

Fixes #461.

@ChrisCummins ChrisCummins added this to the v0.2.1 milestone Oct 11, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2021

Codecov Report

Merging #463 (44d8602) into development (4d8e4dd) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #463      +/-   ##
===============================================
- Coverage        87.58%   87.55%   -0.04%     
===============================================
  Files              109      109              
  Lines             6113     6113              
===============================================
- Hits              5354     5352       -2     
- Misses             759      761       +2     
Impacted Files Coverage Δ
compiler_gym/envs/compiler_env.py 89.47% <100.00%> (+0.05%) ⬆️
compiler_gym/envs/llvm/llvm_env.py 82.17% <100.00%> (-1.16%) ⬇️
compiler_gym/views/observation.py 100.00% <100.00%> (ø)
compiler_gym/envs/llvm/compute_observation.py 87.23% <0.00%> (-2.13%) ⬇️
...loop_tool/service/loop_tool_compilation_session.py 88.59% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8e4dd...44d8602. Read the comment docs.

@ChrisCummins ChrisCummins merged commit 178764f into facebookresearch:development Oct 12, 2021
@ChrisCummins ChrisCummins deleted the issue-461 branch October 12, 2021 13:07
@ChrisCummins ChrisCummins restored the issue-461 branch October 12, 2021 15:23
This was referenced Nov 17, 2021
@ChrisCummins ChrisCummins deleted the issue-461 branch January 19, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Derived observation spaces are unusable during construction time
2 participants