Skip to content

Commit

Permalink
Fix packaging version for minimal install
Browse files Browse the repository at this point in the history
Summary:
As explained in pypa/packaging#631, `packaging v22` completely removes `version.LegacyVersion`. This change breaks `compat.py`.

Unfortunately we cannot check for the version of `packaging` inside of `compat.py`, because `version.parse()` used to return a `version.LegacyVersion` in certain instances, but will now throw an error.

Until a more robust fix is developed, we will have to lock the version of `packaging<22` to avoid build errors.

Reviewed By: peiyizhang

Differential Revision: D42275881

fbshipit-source-id: 9eae10b9400efd24b02b2142d219b8a22d16d99e
  • Loading branch information
Rohan Bopardikar authored and facebook-github-bot committed Dec 29, 2022
1 parent 2422054 commit 5d5c708
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ importlib_metadata; python_version < '3.8'
matplotlib>=2.0.0
numpy>=1.21,<1.22
pandas>=1.0.4,<=1.3.5
packaging<22
python-dateutil>=2.8.0
scikit-learn>=0.24.2
scipy<1.8.0
Expand Down

0 comments on commit 5d5c708

Please sign in to comment.