This repository has been archived by the owner on Nov 3, 2023. It is now read-only.
Tighten the lint a bit #1723
Merged
Tighten the lint a bit #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since it was just a lint run, I don't really want to run datasets tests... |
JackUrb
approved these changes
May 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch description
Adds bugbear to our linter. This is used in fbcode and marks most of the "fatal" lints we get on a sync.
This diff also fixes a bunch of those lints.
Testing steps
Run
flake8 parlai tests. Still not brave enough to go into projectsExpected behavior
Lint passes.
Logs