Skip to content
This repository has been archived by the owner on Nov 3, 2023. It is now read-only.

Add return in report function of wrapper agent #2907

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

dianaglzrico
Copy link
Contributor

@dianaglzrico dianaglzrico commented Jul 30, 2020

Patch description
Agent was breaking because of missing return when calling report().

Testing steps
Unit test:

$ python -m unittest tests.test_wrapper
16:06:36 INFO | creating task(s): wrapper:labelToTextTeacher
.
----------------------------------------------------------------------
Ran 1 test in 0.092s

OK

As stated here this teacher doesn't (and is not expected to) pass python tests/datatests/test_new_tasks.py because of the nature of this task (read link's PR description for a more detailed explanation).

@github-actions
Copy link

Your PR contains a change to a task. Please paste the results of the following command into a comment:

python tests/datatests/test_new_tasks.py

Copy link
Contributor

@EricMichaelSmith EricMichaelSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! (Make sure to paste in the output from python tests/datatests/test_new_tasks.py :) )

@dianaglzrico
Copy link
Contributor Author

Great catch! (Make sure to paste in the output from python tests/datatests/test_new_tasks.py :) )

added unittest and explanation!

@dianaglzrico dianaglzrico merged commit 49442c0 into master Aug 4, 2020
@dianaglzrico dianaglzrico deleted the wrapper-report-fix branch August 4, 2020 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants